linux-kernel - Re: [PATCH 3/3] perf tools: Make 'struct map

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20191014204032.GC15890@krava>
Date:   Mon, 14 Oct 2019 22:40:32 +0200
From:   Jiri Olsa <jolsa@...hat.com>
To:     Andi Kleen <ak@...ux.intel.com>
Cc:     Jiri Olsa <jolsa@...nel.org>,
        Arnaldo Carvalho de Melo <acme@...nel.org>,
        lkml <linux-kernel@...r.kernel.org>,
        Ingo Molnar <mingo@...nel.org>,
        Namhyung Kim <namhyung@...nel.org>,
        Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
        Peter Zijlstra <a.p.zijlstra@...llo.nl>,
        Michael Petlan <mpetlan@...hat.com>
Subject: Re: [PATCH 3/3] perf tools: Make 'struct map_shared' truly shared

On Mon, Oct 14, 2019 at 12:46:19PM -0700, Andi Kleen wrote:
> > > We may need a COW operation for this (hopefully rare) case.
> > 
> > so the jitted mmaps are inserted into the data file
> > and processed during report where they can overload
> > existing maps - thats detected before addition in:
> > 
> >   thread__insert_map
> >     map_groups__fixup_overlappings
> >       - which uses COW way -> map__clone(map, false);
> >         to create new map
> > 
> > other fixups to maps are being done only for kernel maps,
> > where we dont have a problem, because there's only one copy
> 
> I assume the same is true for /tmp/perf-* processing?
> 

perf-*.map processing adds only symbol for dso,
it does not touch maps, so we're fine

  dso__load -> dso__load_perf_map

jirka