linux-kernel - Re: [PATCH] power: reset: at91-poweroff: lookup for proper PMC DT node

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20191014065913.k244l6gdgfiu4jsk@earth.universe>
Date:   Mon, 14 Oct 2019 08:59:13 +0200
From:   Sebastian Reichel <sre@...nel.org>
To:     Claudiu Beznea <claudiu.beznea@...rochip.com>
Cc:     nicolas.ferre@...rochip.com, alexandre.belloni@...tlin.com,
        ludovic.desroches@...rochip.com, linux-pm@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] power: reset: at91-poweroff: lookup for proper PMC DT
 node

Hi,

On Thu, Sep 26, 2019 at 01:25:37PM +0300, Claudiu Beznea wrote:
> Driver has been enabled also for SAM9X60. At the moment the patch which did
> this has been sent to mainline the PMC for SAM9X60 wasn't integrated.
> SAM9X60 has a new PMC compatible (see commit 01e2113de9a5
> ("clk: at91: add sam9x60 pmc driver")). Do to this we have to
> look for proper PMC compatible here, in SHDWC driver.
> 
> Signed-off-by: Claudiu Beznea <claudiu.beznea@...rochip.com>
> ---

Thanks, queued.

-- Sebastian

>  drivers/power/reset/at91-sama5d2_shdwc.c | 8 +++++++-
>  1 file changed, 7 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/power/reset/at91-sama5d2_shdwc.c b/drivers/power/reset/at91-sama5d2_shdwc.c
> index e341cc5c0ea6..1c18f465a245 100644
> --- a/drivers/power/reset/at91-sama5d2_shdwc.c
> +++ b/drivers/power/reset/at91-sama5d2_shdwc.c
> @@ -269,6 +269,12 @@ static const struct of_device_id at91_shdwc_of_match[] = {
>  };
>  MODULE_DEVICE_TABLE(of, at91_shdwc_of_match);
>  
> +static const struct of_device_id at91_pmc_ids[] = {
> +	{ .compatible = "atmel,sama5d2-pmc" },
> +	{ .compatible = "microchip,sam9x60-pmc" },
> +	{ /* Sentinel. */ }
> +};
> +
>  static int __init at91_shdwc_probe(struct platform_device *pdev)
>  {
>  	struct resource *res;
> @@ -313,7 +319,7 @@ static int __init at91_shdwc_probe(struct platform_device *pdev)
>  
>  	at91_shdwc_dt_configure(pdev);
>  
> -	np = of_find_compatible_node(NULL, NULL, "atmel,sama5d2-pmc");
> +	np = of_find_matching_node(NULL, at91_pmc_ids);
>  	if (!np) {
>  		ret = -ENODEV;
>  		goto clk_disable;
> -- 
> 2.7.4
> 

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)