linux-kernel - Re: [PATCH v2] pidfd: avoid linux/wait.h and sys/wait.h name clashes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <BXQCOYS7J0NU.363NAWEEPN3GH@wittgenstein>
Date:   Tue, 15 Oct 2019 21:38:59 +0200
From:   "Christian Brauner" <christian.brauner@...ntu.com>
To:     "Christian Kellner" <ckellner@...hat.com>,
        <linux-kernel@...r.kernel.org>
Cc:     "Christian Kellner" <christian@...lner.me>,
        "Christian Brauner" <christian@...uner.io>,
        "Shuah Khan" <shuah@...nel.org>, <linux-kselftest@...r.kernel.org>
Subject: Re: [PATCH v2] pidfd: avoid linux/wait.h and sys/wait.h name
 clashes

On Tue Oct 15, 2019 at 6:55 PM Christian Kellner wrote:
> From: Christian Kellner <christian@...lner.me>
> 
> Both linux/wait.h and sys/wait.h contain values for the first argument
> of 'waitid' (P_ALL, P_PID, ...).  While the former uses defines the
> latter uses an enum. When linux/wait.h is included before sys/wait.h
> this will lead to an error, because P_ALL, P_PID, ... will already
> have been substituted to 0, 1, ... respectively and this the resulting
> code will be 'typedef enum {0, 1, ...'.
> Remove 'linux/wait.h' and rename P_PIDFD to avoid a future clash, in
> case P_PIDFD gets added to the idtype_t enum in sys/wait.h.
> 
> Signed-off-by: Christian Kellner <christian@...lner.me>

Reviewed-by: Christian Brauner <christian.brauner@...ntu.com>