linux-kernel - Re: [PATCH] PCI: sysfs: remove pci_bridge_groups and pcie_dev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 15 Oct 2019 16:21:15 -0500
From:   Bjorn Helgaas <helgaas@...nel.org>
To:     Ben Dooks <ben.dooks@...ethink.co.uk>
Cc:     linux-kernel@...ts.codethink.co.uk, linux-pci@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] PCI: sysfs: remove pci_bridge_groups and pcie_dev_groups

On Tue, Oct 15, 2019 at 03:00:59PM +0100, Ben Dooks wrote:
> The pci_bridge_groups and pcie_dev_groups objects are
> not exported and not used at-all, so remove them to
> fix the following warnings from sparse:
> 
> drivers/pci/pci-sysfs.c:1546:30: warning: symbol 'pci_bridge_groups' was not declared. Should it be static?
> drivers/pci/pci-sysfs.c:1555:30: warning: symbol 'pcie_dev_groups' was not declared. Should it be static?
> 
> Signed-off-by: Ben Dooks <ben.dooks@...ethink.co.uk>
> ---
> Cc: Bjorn Helgaas <bhelgaas@...gle.com>
> Cc: linux-pci@...r.kernel.org
> Cc: linux-kernel@...r.kernel.org
> ---
>  drivers/pci/pci-sysfs.c | 10 ----------
>  1 file changed, 10 deletions(-)
> 
> diff --git a/drivers/pci/pci-sysfs.c b/drivers/pci/pci-sysfs.c
> index 793412954529..f7028cf3649a 100644
> --- a/drivers/pci/pci-sysfs.c
> +++ b/drivers/pci/pci-sysfs.c
> @@ -1543,20 +1543,10 @@ static const struct attribute_group pci_bridge_group = {
>  	.attrs = pci_bridge_attrs,
>  };
>  
> -const struct attribute_group *pci_bridge_groups[] = {
> -	&pci_bridge_group,
> -	NULL,
> -};
> -
>  static const struct attribute_group pcie_dev_group = {
>  	.attrs = pcie_dev_attrs,
>  };
>  
> -const struct attribute_group *pcie_dev_groups[] = {
> -	&pcie_dev_group,
> -	NULL,
> -};
> -
>  static const struct attribute_group pci_dev_hp_attr_group = {
>  	.attrs = pci_dev_hp_attrs,
>  	.is_visible = pci_dev_hp_attrs_are_visible,

I find the sysfs attribute/group/groups stuff quite confusing, but
aren't these now unused also?

  pci_bridge_group
  pcie_dev_group