[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20191015222421.GA184682@google.com>
Date: Tue, 15 Oct 2019 17:24:21 -0500
From: Bjorn Helgaas <helgaas@...nel.org>
To: Rajat Jain <rajatja@...gle.com>
Cc: gregkh@...uxfoundation.com, linux-pci@...r.kernel.org,
linux-kernel@...r.kernel.org, rajatxjain@...il.com
Subject: Re: [PATCH v3 1/2] PCI/AER: Add PoisonTLPBlocked to Uncorrectable
errors
On Tue, Aug 27, 2019 at 03:21:44PM -0700, Rajat Jain wrote:
> The elements in the aer_uncorrectable_error_string[] refer to
> the bit names in Uncorrectable Error status Register in the PCIe spec
> (Sec 7.8.4.2 in PCIe 4.0)
>
> Add the last error bit in the strings array that was missing.
>
> Signed-off-by: Rajat Jain <rajatja@...gle.com>
I applied this to pci/aer for v5.5, thanks, Rajat!
> ---
> v3: same as v2
> v2: same as v1
>
> drivers/pci/pcie/aer.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/pci/pcie/aer.c b/drivers/pci/pcie/aer.c
> index b45bc47d04fe..68060a290291 100644
> --- a/drivers/pci/pcie/aer.c
> +++ b/drivers/pci/pcie/aer.c
> @@ -36,7 +36,7 @@
> #define AER_ERROR_SOURCES_MAX 128
>
> #define AER_MAX_TYPEOF_COR_ERRS 16 /* as per PCI_ERR_COR_STATUS */
> -#define AER_MAX_TYPEOF_UNCOR_ERRS 26 /* as per PCI_ERR_UNCOR_STATUS*/
> +#define AER_MAX_TYPEOF_UNCOR_ERRS 27 /* as per PCI_ERR_UNCOR_STATUS*/
>
> struct aer_err_source {
> unsigned int status;
> @@ -560,6 +560,7 @@ static const char *aer_uncorrectable_error_string[AER_MAX_TYPEOF_UNCOR_ERRS] = {
> "BlockedTLP", /* Bit Position 23 */
> "AtomicOpBlocked", /* Bit Position 24 */
> "TLPBlockedErr", /* Bit Position 25 */
> + "PoisonTLPBlocked", /* Bit Position 26 */
> };
>
> static const char *aer_agent_string[] = {
> --
> 2.23.0.187.g17f5b7556c-goog
>
Powered by blists - more mailing lists