linux-kernel - Re: [PATCH net-next v2] net: bcmgenet: Generate a random MAC if none is valid

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20191015153955.2e602903@cakuba.netronome.com>
Date:   Tue, 15 Oct 2019 15:39:55 -0700
From:   Jakub Kicinski <jakub.kicinski@...ronome.com>
To:     Scott Branden <scott.branden@...adcom.com>
Cc:     Florian Fainelli <f.fainelli@...il.com>, netdev@...r.kernel.org,
        phil@...pberrypi.org, jonathan@...pberrypi.org,
        matthias.bgg@...nel.org, linux-rpi-kernel@...ts.infradead.org,
        wahrenst@....net, nsaenzjulienne@...e.de,
        Doug Berger <opendmb@...il.com>,
        "David S. Miller" <davem@...emloft.net>,
        bcm-kernel-feedback-list@...adcom.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next v2] net: bcmgenet: Generate a random MAC if
 none is valid

On Tue, 15 Oct 2019 15:32:28 -0700, Scott Branden wrote:
> > @@ -3482,7 +3476,12 @@ static int bcmgenet_probe(struct platform_device *pdev)
> >   
> >   	SET_NETDEV_DEV(dev, &pdev->dev);
> >   	dev_set_drvdata(&pdev->dev, dev);
> > -	ether_addr_copy(dev->dev_addr, macaddr);
> > +	if (IS_ERR_OR_NULL(macaddr) || !is_valid_ether_addr(macaddr)) {
> > +		dev_warn(&pdev->dev, "using random Ethernet MAC\n");  
> 
> I would still consider this warrants a dev_err as you should not be 
> using the device with a random MAC address assigned to it.  But I'll 
> leave it to the "experts" to decide on the print level here.

FWIW I'd stick to warn for this message since this is no longer a hard
failure.