linux-kernel - Re: [PATCH] fs: include internal.h for missing declarations

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20191015080557.GC21550@quack2.suse.cz>
Date:   Tue, 15 Oct 2019 10:05:57 +0200
From:   Jan Kara <jack@...e.cz>
To:     Ben Dooks <ben.dooks@...ethink.co.uk>
Cc:     linux-kernel@...ts.codethink.co.uk,
        Alexander Viro <viro@...iv.linux.org.uk>,
        linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] fs: include internal.h for missing declarations

On Fri 11-10-19 18:00:39, Ben Dooks wrote:
> The declarations of __block_write_begin_int and guard_bio_eod
> are needed from internal.h so include it to fix the following
> sparse warnings:
> 
> fs/buffer.c:1930:5: warning: symbol '__block_write_begin_int' was not declared. Should it be static?
> fs/buffer.c:2994:6: warning: symbol 'guard_bio_eod' was not declared. Should it be static?
> 
> Signed-off-by: Ben Dooks <ben.dooks@...ethink.co.uk>

OK, makes sense to keep declarations in sync with real functions. Thanks
for the patch a feel free to add:

Reviewed-by: Jan Kara <jack@...e.cz>

								Honza

> ---
> Cc: Alexander Viro <viro@...iv.linux.org.uk>
> Cc: linux-fsdevel@...r.kernel.org
> Cc: linux-kernel@...r.kernel.org
> ---
>  fs/buffer.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/fs/buffer.c b/fs/buffer.c
> index 86a38b979323..792f22a88e67 100644
> --- a/fs/buffer.c
> +++ b/fs/buffer.c
> @@ -48,6 +48,8 @@
>  #include <linux/sched/mm.h>
>  #include <trace/events/block.h>
>  
> +#include "internal.h"
> +
>  static int fsync_buffers_list(spinlock_t *lock, struct list_head *list);
>  static int submit_bh_wbc(int op, int op_flags, struct buffer_head *bh,
>  			 enum rw_hint hint, struct writeback_control *wbc);
> -- 
> 2.23.0
> 
-- 
Jan Kara <jack@...e.com>
SUSE Labs, CR