linux-kernel - Re: [PATCH] microblaze: Include generic support for MSI irqdomains

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <7cedfc62-b9ba-d1f2-e14f-93a64ad07fbc@xilinx.com>
Date:   Tue, 15 Oct 2019 10:46:45 +0200
From:   Michal Simek <michal.simek@...inx.com>
To:     Christoph Hellwig <hch@...radead.org>,
        Michal Simek <michal.simek@...inx.com>,
        Bjorn Helgaas <bhelgaas@...gle.com>
Cc:     linux-kernel@...r.kernel.org, monstr@...str.eu, git@...inx.com,
        Kate Stewart <kstewart@...uxfoundation.org>,
        Kuldeep Dave <kuldeep.dave@...inx.com>,
        Albert Ou <aou@...s.berkeley.edu>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Palmer Dabbelt <palmer@...ive.com>,
        Masahiro Yamada <yamada.masahiro@...ionext.com>,
        Firoz Khan <firoz.khan@...aro.org>,
        Paul Walmsley <paul.walmsley@...ive.com>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Will Deacon <will@...nel.org>, linux-riscv@...ts.infradead.org,
        linux-kbuild@...r.kernel.org
Subject: Re: [PATCH] microblaze: Include generic support for MSI irqdomains

On 15. 10. 19 9:47, Christoph Hellwig wrote:
> On Thu, Oct 10, 2019 at 12:47:31PM +0200, Michal Simek wrote:
>> On 08. 10. 19 17:46, Christoph Hellwig wrote:
>>> On Tue, Oct 08, 2019 at 12:34:47PM +0200, Michal Simek wrote:
>>>> index e5c9170a07fc..83417105c00a 100644
>>>> --- a/arch/microblaze/include/asm/Kbuild
>>>> +++ b/arch/microblaze/include/asm/Kbuild
>>>> @@ -25,6 +25,7 @@ generic-y += local64.h
>>>>  generic-y += mcs_spinlock.h
>>>>  generic-y += mm-arch-hooks.h
>>>>  generic-y += mmiowb.h
>>>> +generic-y += msi.h
>>>
>>> Please just mark it as mandatory-y in the asm-generic makefile
>>> instead of requiring a sniplet for every architecture.
>>>
>>
>> But is it really mandatory for all architectures?
> 
> What the mandatory-y keyword means is that every architecture that
> doesn't provide its own header gets the default one, which seems
> applicable here.  Maybe the keyword is a bit misnamed and should be
> default-y or something like that..
> 
> But in this case I think we have a clear case of x86 vs the rest, which
> is unlikely to change in a major way.
> 

Bjorn: If you are ok with this I will make the patch.

Thanks,
Michal