linux-kernel - Re: [PATCH] random: inform about bootloader-provided randomness

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 15 Oct 2019 17:44:53 +0800
From:   Hsin-Yi Wang <hsinyi@...omium.org>
To:     Will Deacon <will@...nel.org>
Cc:     Dominik Brodowski <linux@...inikbrodowski.net>,
        Ard Biesheuvel <ard.biesheuvel@...aro.org>,
        Stephen Boyd <swboyd@...omium.org>,
        Rob Herring <robh@...nel.org>, "Theodore Ts'o" <tytso@....edu>,
        lkml <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] random: inform about bootloader-provided randomness

On Tue, Oct 15, 2019 at 8:40 AM Will Deacon <will@...nel.org> wrote:
>
> On Sat, Oct 05, 2019 at 01:36:32PM +0200, Dominik Brodowski wrote:
> > Inform how many bits of randomness were provided by the bootloader,
> > and whether we trust that input.
> >
> > Signed-off-by: Dominik Brodowski <linux@...inikbrodowski.net>
> > Cc: Ard Biesheuvel <ard.biesheuvel@...aro.org>
> > Cc: Hsin-Yi Wang <hsinyi@...omium.org>
> > Cc: Stephen Boyd <swboyd@...omium.org>
> > Cc: Rob Herring <robh@...nel.org>
> > Cc: Theodore Ts'o <tytso@....edu>
> > Cc: Will Deacon <will@...nel.org>
> >
> > diff --git a/drivers/char/random.c b/drivers/char/random.c
> > index de434feb873a..673375e05c0d 100644
> > --- a/drivers/char/random.c
> > +++ b/drivers/char/random.c
> > @@ -2515,6 +2515,10 @@ EXPORT_SYMBOL_GPL(add_hwgenerator_randomness);
> >   */
> >  void add_bootloader_randomness(const void *buf, unsigned int size)
> >  {
> > +     pr_notice("random: adding %u bits of %sbootloader-provided randomness",
> > +             size * 8,
> > +             IS_ENABLED(CONFIG_RANDOM_TRUST_BOOTLOADER) ? "trusted " : "");
> > +
> >       if (IS_ENABLED(CONFIG_RANDOM_TRUST_BOOTLOADER))
> >               add_hwgenerator_randomness(buf, size, size * 8);
> >       else
>
> Looks fine to me:
>
> Acked-by: Will Deacon <will@...nel.org>
>
> Will

Thanks.

Acked-by: Hsin-Yi Wang <hsinyi@...omium.org>