linux-kernel - Re: [PATCH v4 2/2] pidfd: add tests for NSpid info in fdinfo

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20191015100743.t6gowsic7c347ldv@wittgenstein>
Date:   Tue, 15 Oct 2019 12:07:44 +0200
From:   Christian Brauner <christian.brauner@...ntu.com>
To:     Christian Kellner <ckellner@...hat.com>
Cc:     linux-kernel@...r.kernel.org, linux-api@...r.kernel.org,
        Jann Horn <jannh@...gle.com>,
        Christian Kellner <christian@...lner.me>,
        Christian Brauner <christian@...ntu.com>,
        Shuah Khan <shuah@...nel.org>,
        Andrew Morton <akpm@...ux-foundation.org>,
        "Peter Zijlstra (Intel)" <peterz@...radead.org>,
        Ingo Molnar <mingo@...nel.org>, Michal Hocko <mhocko@...e.com>,
        Thomas Gleixner <tglx@...utronix.de>,
        Elena Reshetova <elena.reshetova@...el.com>,
        Roman Gushchin <guro@...com>,
        Andrea Arcangeli <aarcange@...hat.com>,
        Al Viro <viro@...iv.linux.org.uk>,
        Aleksa Sarai <cyphar@...har.com>,
        "Dmitry V. Levin" <ldv@...linux.org>,
        linux-kselftest@...r.kernel.org
Subject: Re: [PATCH v4 2/2] pidfd: add tests for NSpid info in fdinfo

On Mon, Oct 14, 2019 at 06:20:33PM +0200, Christian Kellner wrote:
> From: Christian Kellner <christian@...lner.me>
> 
> Add a test that checks that if pid namespaces are configured the fdinfo
> file of a pidfd contains an NSpid: entry containing the process id in
> the current and additionally all nested namespaces. In the case that
> a pidfd is from a pid namespace not in the same namespace hierarchy as
> the process accessing the fdinfo file, ensure the 'NSpid' shows 0 for
> that pidfd, analogous to the 'Pid' entry.
> 
> Signed-off-by: Christian Kellner <christian@...lner.me>

That looks reasonable to me.

Acked-by: Christian Brauner <christian.brauner@...ntu.com>