linux-kernel - Re: [PATCH v2] sched/topology: Allow sched_asym

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a3a1a3d9-5d3a-3ab3-0eaf-e63e0c401c99@arm.com>
Date:   Tue, 15 Oct 2019 11:58:34 +0100
From:   Valentin Schneider <valentin.schneider@....com>
To:     Quentin Perret <qperret@...gle.com>
Cc:     linux-kernel@...r.kernel.org, mingo@...nel.org,
        peterz@...radead.org, vincent.guittot@...aro.org,
        Dietmar.Eggemann@....com, morten.rasmussen@....com,
        stable@...r.kernel.org
Subject: Re: [PATCH v2] sched/topology: Allow sched_asym_cpucapacity to be
 disabled

On 15/10/2019 11:40, Quentin Perret wrote:
>> @@ -2124,8 +2124,17 @@ static void detach_destroy_domains(const struct cpumask *cpu_map)
>>  	int i;
>>  
>>  	rcu_read_lock();
>> +
>> +	if (static_key_enabled(&sched_asym_cpucapacity)) {
>> +		unsigned int cpu = cpumask_any(cpu_map);
>> +
>> +		if (rcu_dereference(per_cpu(sd_asym_cpucapacity, cpu)))
>> +			static_branch_dec_cpuslocked(&sched_asym_cpucapacity);
> 
> Lockdep should scream for this :)

Bleh, yes indeed...

>> +	}
>> +
>>  	for_each_cpu(i, cpu_map)
>>  		cpu_attach_domain(NULL, &def_root_domain, i);
>> +
>>  	rcu_read_unlock();
>>  }
>>  
>> -- 
>> 2.22.0
>>