linux-kernel - RE: [PATCH v3 1/3] Drivers: hv: vmbus: Introduce table of VMBus protocol versions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <DM5PR21MB01374065971D72A1817C1DC2D7930@DM5PR21MB0137.namprd21.prod.outlook.com>
Date:   Tue, 15 Oct 2019 13:08:51 +0000
From:   Michael Kelley <mikelley@...rosoft.com>
To:     Andrea Parri <parri.andrea@...il.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-hyperv@...r.kernel.org" <linux-hyperv@...r.kernel.org>
CC:     KY Srinivasan <kys@...rosoft.com>,
        Haiyang Zhang <haiyangz@...rosoft.com>,
        Stephen Hemminger <sthemmin@...rosoft.com>,
        Sasha Levin <sashal@...nel.org>,
        vkuznets <vkuznets@...hat.com>, Dexuan Cui <decui@...rosoft.com>,
        Wei Liu <wei.liu@...nel.org>
Subject: RE: [PATCH v3 1/3] Drivers: hv: vmbus: Introduce table of VMBus
 protocol versions

From: Andrea Parri <parri.andrea@...il.com> Sent: Tuesday, October 15, 2019 4:47 AM
> 
> The technique used to get the next VMBus version seems increasisly
> clumsy as the number of VMBus versions increases.  Performance is
> not a concern since this is only done once during system boot; it's
> just that we'll end up with more lines of code than is really needed.
> 
> As an alternative, introduce a table with the version numbers listed
> in order (from the most recent to the oldest).  vmbus_connect() loops
> through the versions listed in the table until it gets an accepted
> connection or gets to the end of the table (invalid version).
> 
> Suggested-by: Michael Kelley <mikelley@...rosoft.com>
> Signed-off-by: Andrea Parri <parri.andrea@...il.com>
> ---
>  drivers/hv/connection.c | 50 +++++++++++++++--------------------------
>  drivers/hv/vmbus_drv.c  |  3 +--
>  include/linux/hyperv.h  |  4 ----
>  3 files changed, 19 insertions(+), 38 deletions(-)
> 

Reviewed-by: Michael Kelley <mikelley@...rosoft.com>