linux-kernel - [PATCH] userns: do not export uidhash

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-Id: <20191015132032.7943-1-ben.dooks@codethink.co.uk>
Date:   Tue, 15 Oct 2019 14:20:32 +0100
From:   Ben Dooks <ben.dooks@...ethink.co.uk>
To:     linux-kernel@...ts.codethink.co.uk
Cc:     Ben Dooks <ben.dooks@...ethink.co.uk>, linux-kernel@...r.kernel.org
Subject: [PATCH] userns: do not export uidhash_table

The uidhash_table is not exported from this file, so
make it static to avoid the following sparse warning:

kernel/user.c:85:19: warning: symbol 'uidhash_table' was not declared. Should it be static?

Signed-off-by: Ben Dooks <ben.dooks@...ethink.co.uk>
---
Cc: linux-kernel@...r.kernel.org
---
 kernel/user.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/kernel/user.c b/kernel/user.c
index 5235d7f49982..b1635d94a1f2 100644
--- a/kernel/user.c
+++ b/kernel/user.c
@@ -82,7 +82,7 @@ EXPORT_SYMBOL_GPL(init_user_ns);
 #define uidhashentry(uid)	(uidhash_table + __uidhashfn((__kuid_val(uid))))
 
 static struct kmem_cache *uid_cachep;
-struct hlist_head uidhash_table[UIDHASH_SZ];
+static struct hlist_head uidhash_table[UIDHASH_SZ];
 
 /*
  * The uidhash_lock is mostly taken from process context, but it is
-- 
2.23.0