linux-kernel - Re: [PATCH] soc: imx: gpc: fix initialiser format

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 15 Oct 2019 16:11:07 +0200
From:   Lucas Stach <l.stach@...gutronix.de>
To:     Ben Dooks <ben.dooks@...ethink.co.uk>,
        linux-kernel@...ts.codethink.co.uk
Cc:     Shawn Guo <shawnguo@...nel.org>,
        Sascha Hauer <s.hauer@...gutronix.de>,
        linux-kernel@...r.kernel.org, NXP Linux Team <linux-imx@....com>,
        Pengutronix Kernel Team <kernel@...gutronix.de>,
        Fabio Estevam <festevam@...il.com>,
        linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH] soc: imx: gpc: fix initialiser format

On Di, 2019-10-15 at 15:09 +0100, Ben Dooks wrote:
> Make the initialiers in imx_gpc_domains C99 format to fix the
> following sparse warnings:
> 
> drivers/soc/imx/gpc.c:252:30: warning: obsolete array initializer, use C99 syntax
> drivers/soc/imx/gpc.c:258:29: warning: obsolete array initializer, use C99 syntax
> drivers/soc/imx/gpc.c:269:34: warning: obsolete array initializer, use C99 syntax
> drivers/soc/imx/gpc.c:278:30: warning: obsolete array initializer, use C99 syntax
> 
> Signed-off-by: Ben Dooks <ben.dooks@...ethink.co.uk>

Reviewed-by: Lucas Stach <l.stach@...gutronix.de>

> ---
> Cc: Shawn Guo <shawnguo@...nel.org>
> Cc: Sascha Hauer <s.hauer@...gutronix.de>
> Cc: Pengutronix Kernel Team <kernel@...gutronix.de>
> Cc: Fabio Estevam <festevam@...il.com>
> Cc: NXP Linux Team <linux-imx@....com>
> Cc: linux-arm-kernel@...ts.infradead.org
> Cc: linux-kernel@...r.kernel.org
> ---
>  drivers/soc/imx/gpc.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/soc/imx/gpc.c b/drivers/soc/imx/gpc.c
> index d9231bd3c691..98b9d9a902ae 100644
> --- a/drivers/soc/imx/gpc.c
> +++ b/drivers/soc/imx/gpc.c
> @@ -249,13 +249,13 @@ static struct genpd_power_state imx6_pm_domain_pu_state = {
>  };
>  
>  static struct imx_pm_domain imx_gpc_domains[] = {
> -	[GPC_PGC_DOMAIN_ARM] {
> +	[GPC_PGC_DOMAIN_ARM] = {
>  		.base = {
>  			.name = "ARM",
>  			.flags = GENPD_FLAG_ALWAYS_ON,
>  		},
>  	},
> -	[GPC_PGC_DOMAIN_PU] {
> +	[GPC_PGC_DOMAIN_PU] = {
>  		.base = {
>  			.name = "PU",
>  			.power_off = imx6_pm_domain_power_off,
> @@ -266,7 +266,7 @@ static struct imx_pm_domain imx_gpc_domains[] = {
>  		.reg_offs = 0x260,
>  		.cntr_pdn_bit = 0,
>  	},
> -	[GPC_PGC_DOMAIN_DISPLAY] {
> +	[GPC_PGC_DOMAIN_DISPLAY] = {
>  		.base = {
>  			.name = "DISPLAY",
>  			.power_off = imx6_pm_domain_power_off,
> @@ -275,7 +275,7 @@ static struct imx_pm_domain imx_gpc_domains[] = {
>  		.reg_offs = 0x240,
>  		.cntr_pdn_bit = 4,
>  	},
> -	[GPC_PGC_DOMAIN_PCI] {
> +	[GPC_PGC_DOMAIN_PCI] = {
>  		.base = {
>  			.name = "PCI",
>  			.power_off = imx6_pm_domain_power_off,