[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <996277d6-1c0b-6080-4565-ce3aad77e09e@axentia.se>
Date: Tue, 15 Oct 2019 15:15:06 +0000
From: Peter Rosin <peda@...ntia.se>
To: Biwen Li <biwen.li@....com>,
"leoyang.li@....com" <leoyang.li@....com>,
"robh+dt@...nel.org" <robh+dt@...nel.org>,
"mark.rutland@....com" <mark.rutland@....com>
CC: "linux-i2c@...r.kernel.org" <linux-i2c@...r.kernel.org>,
"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>
Subject: Re: [v2,1/2] dt-bindings: i2c: add property idle-state
On 2019-10-15 06:48, Biwen Li wrote:
> This adds property idle-state
>
> Signed-off-by: Biwen Li <biwen.li@....com>
> ---
> Change in v2:
> - update subject and description
> - add property idle-state
>
> Documentation/devicetree/bindings/i2c/i2c-mux-pca954x.txt | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/Documentation/devicetree/bindings/i2c/i2c-mux-pca954x.txt b/Documentation/devicetree/bindings/i2c/i2c-mux-pca954x.txt
> index 30ac6a60f041..2c7875d338fb 100644
> --- a/Documentation/devicetree/bindings/i2c/i2c-mux-pca954x.txt
> +++ b/Documentation/devicetree/bindings/i2c/i2c-mux-pca954x.txt
> @@ -34,6 +34,7 @@ Optional Properties:
> - first cell is the pin number
> - second cell is used to specify flags.
> See also Documentation/devicetree/bindings/interrupt-controller/interrupts.txt
> + - idle-state: Please refer to Documentation/devicetree/bindings/mux/mux-controller.txt
>
> Example:
>
>
As per my comments on the code, you should mention that idle-state, if present,
overrides i2c-mux-idle-disconnect. I also think you should keep idle-state
and i2c-mux-idle-disconnect right next to each other.
Cheers,
Peter
Powered by blists - more mailing lists