lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <000e01d5836b$ac871190$059534b0$@samsung.com>
Date:   Tue, 15 Oct 2019 20:47:32 +0530
From:   "Pankaj Dubey" <pankaj.dubey@...sung.com>
To:     "'Christoph Hellwig'" <hch@...radead.org>
Cc:     <linux-pci@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <bhelgaas@...gle.com>, <andrew.murray@....com>,
        <lorenzo.pieralisi@....com>, <gustavo.pimentel@...opsys.com>,
        <jingoohan1@...il.com>, <vidyas@...dia.com>,
        "'Anvesh Salveru'" <anvesh.s@...sung.com>
Subject: RE: [PATCH v3] PCI: dwc: Add support to add GEN3 related
 equalization quirks



> -----Original Message-----
> From: 'Christoph Hellwig' <hch@...radead.org>
> Sent: Tuesday, October 15, 2019 2:36 PM
> To: Pankaj Dubey <pankaj.dubey@...sung.com>
> Cc: 'Christoph Hellwig' <hch@...radead.org>; linux-pci@...r.kernel.org;
linux-
> kernel@...r.kernel.org; bhelgaas@...gle.com; andrew.murray@....com;
> lorenzo.pieralisi@....com; gustavo.pimentel@...opsys.com;
> jingoohan1@...il.com; vidyas@...dia.com; 'Anvesh Salveru'
> <anvesh.s@...sung.com>
> Subject: Re: [PATCH v3] PCI: dwc: Add support to add GEN3 related
equalization
> quirks
> 
> On Tue, Oct 15, 2019 at 02:28:00PM +0530, Pankaj Dubey wrote:
> > Is this something mandatory?
> >
> > As we discussed during first patch-set here [1] with Andrew, we have
> > need of this patch (along with some other stuffs, which will be sent
> > soon), to clean up our internal driver and make it ready for upstream.
> > As of today we have some internal restrictions where we can't make it
> > to upstream along with this patch.
> 
> We don't add code to the kernel without actual users.

OK, but do we think the current driver has only code which is being used by
some user?
At least I can see current driver has some features which is not being used
by any current driver.  

I will leave this call up-to the maintainers.
IMO, This being an DWC H/W IP feature, for me it makes sense to have it in
DWC controller driver as long as it does not break any existing
functionality, irrespective of actual user is present or not. 

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ