linux-kernel - Re: [PATCH net-next] net: bcmgenet: Add a shutdown callback

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <81a0edb7-efa9-2abd-6158-52504efab913@gmail.com>
Date:   Tue, 15 Oct 2019 10:45:35 -0700
From:   Doug Berger <opendmb@...il.com>
To:     Florian Fainelli <f.fainelli@...il.com>, netdev@...r.kernel.org
Cc:     "David S. Miller" <davem@...emloft.net>,
        "open list:BROADCOM GENET ETHERNET DRIVER" 
        <bcm-kernel-feedback-list@...adcom.com>,
        open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH net-next] net: bcmgenet: Add a shutdown callback

On 10/15/19 10:36 AM, Florian Fainelli wrote:
> Make sure that we completely quiesce the network device, including its
> DMA to avoid having it continue to receive packets while there is no
> software alive to service those.
> 
> Signed-off-by: Florian Fainelli <f.fainelli@...il.com>
> ---
>  drivers/net/ethernet/broadcom/genet/bcmgenet.c | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/drivers/net/ethernet/broadcom/genet/bcmgenet.c b/drivers/net/ethernet/broadcom/genet/bcmgenet.c
> index 12cb77ef1081..ecbb1e7353ba 100644
> --- a/drivers/net/ethernet/broadcom/genet/bcmgenet.c
> +++ b/drivers/net/ethernet/broadcom/genet/bcmgenet.c
> @@ -3597,6 +3597,11 @@ static int bcmgenet_remove(struct platform_device *pdev)
>  	return 0;
>  }
>  
> +static void bcmgenet_shutdown(struct platform_device *pdev)
> +{
> +	bcmgenet_remove(pdev);
> +}
> +
>  #ifdef CONFIG_PM_SLEEP
>  static int bcmgenet_resume(struct device *d)
>  {
> @@ -3715,6 +3720,7 @@ static SIMPLE_DEV_PM_OPS(bcmgenet_pm_ops, bcmgenet_suspend, bcmgenet_resume);
>  static struct platform_driver bcmgenet_driver = {
>  	.probe	= bcmgenet_probe,
>  	.remove	= bcmgenet_remove,
> +	.shutdown = bcmgenet_shutdown,
>  	.driver	= {
>  		.name	= "bcmgenet",
>  		.of_match_table = bcmgenet_match,
> 

Acked-by: Doug Berger <opendmb@...il.com>