linux-kernel - Re: [PATCH 04/12] xfs: refactor the ioend merging code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20191015175940.GA11481@lst.de>
Date:   Tue, 15 Oct 2019 19:59:40 +0200
From:   Christoph Hellwig <hch@....de>
To:     "Darrick J. Wong" <darrick.wong@...cle.com>
Cc:     Christoph Hellwig <hch@....de>,
        Damien Le Moal <Damien.LeMoal@....com>,
        Andreas Gruenbacher <agruenba@...hat.com>,
        linux-xfs@...r.kernel.org, linux-fsdevel@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 04/12] xfs: refactor the ioend merging code

On Tue, Oct 15, 2019 at 10:56:19AM -0700, Darrick J. Wong wrote:
> On Tue, Oct 15, 2019 at 05:43:37PM +0200, Christoph Hellwig wrote:
> > Introduce two nicely abstracted helper, which can be moved to the
> > iomap code later.  Also use list_pop_entry and list_first_entry_or_null
> > to simplify the code a bit.
> 
> No we don't use these....     ^^^^^^^^^^^^^^

list_first_entry_or_null is used, only list_pop_entry isn't, so that
needs to be removed.