linux-kernel - Re: [PATCH] staging: iio: ad9834: add a check for devm_clk

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20191016150212.GD24678@kadam>
Date:   Wed, 16 Oct 2019 18:02:12 +0300
From:   Dan Carpenter <dan.carpenter@...cle.com>
To:     Chuhong Yuan <hslester96@...il.com>
Cc:     devel@...verdev.osuosl.org, Lars-Peter Clausen <lars@...afoo.de>,
        Stefan Popa <stefan.popa@...log.com>,
        Michael Hennerich <Michael.Hennerich@...log.com>,
        linux-iio@...r.kernel.org,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        linux-kernel@...r.kernel.org,
        Peter Meerwald-Stadler <pmeerw@...erw.net>,
        Hartmut Knaack <knaack.h@....de>,
        Jonathan Cameron <jic23@...nel.org>
Subject: Re: [PATCH] staging: iio: ad9834: add a check for devm_clk_get

On Wed, Oct 16, 2019 at 10:25:40PM +0800, Chuhong Yuan wrote:
> ad9834_probe misses a check for devm_clk_get and may cause problems.
> Add a check like what ad9832 does to fix it.
> 
> Signed-off-by: Chuhong Yuan <hslester96@...il.com>

Looks good.

Reviewed-by: Dan Carpenter <dan.carpenter@...cle.com>

regards,
dan carpenter