linux-kernel - Re: [PATCH] clocksource/drivers/sh_mtu2: Do not loop using platform_get_irq_by

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e8e88948-8dc3-5d89-c9bd-83d20de7ee16@linaro.org>
Date:   Wed, 16 Oct 2019 17:06:37 +0200
From:   Daniel Lezcano <daniel.lezcano@...aro.org>
To:     Geert Uytterhoeven <geert+renesas@...der.be>,
        Thomas Gleixner <tglx@...utronix.de>
Cc:     Stephen Boyd <swboyd@...omium.org>,
        linux-renesas-soc@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] clocksource/drivers/sh_mtu2: Do not loop using
 platform_get_irq_by_name()

On 16/10/2019 16:30, Geert Uytterhoeven wrote:
> As platform_get_irq_by_name() now prints an error when the interrupt
> does not exist, looping over possibly non-existing interrupts causes the
> printing of scary messages like:
> 
>     sh_mtu2 fcff0000.timer: IRQ tgi1a not found
>     sh_mtu2 fcff0000.timer: IRQ tgi2a not found
> 
> Fix this by using the platform_irq_count() helper, to avoid touching
> non-existent interrupts.  Limit the returned number of interrupts to the
> maximum number of channels currently supported by the driver in a
> future-proof way, i.e. using ARRAY_SIZE() instead of a hardcoded number.
> 
> Fixes: 7723f4c5ecdb8d83 ("driver core: platform: Add an error message to platform_get_irq*()")
> Signed-off-by: Geert Uytterhoeven <geert+renesas@...der.be>
> ---
> This is a fix for v5.4.
> ---

Applied, thanks!


-- 
 <http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog