linux-kernel - Re: [PATCH -next] ipmi: bt-bmc: use devm_platform_ioremap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <789af3ff-9ed8-5869-05c4-9cfb2ac5e9d5@kaod.org>
Date:   Wed, 16 Oct 2019 16:41:07 +0200
From:   Cédric Le Goater <clg@...d.org>
To:     minyard@....org, YueHaibing <yuehaibing@...wei.com>
Cc:     arnd@...db.de, gregkh@...uxfoundation.org,
        openipmi-developer@...ts.sourceforge.net,
        linux-kernel@...r.kernel.org,
        Alistair Popple <alistair@...ple.id.au>
Subject: Re: [PATCH -next] ipmi: bt-bmc: use devm_platform_ioremap_resource()
 to simplify code

On 16/10/2019 16:19, Corey Minyard wrote:
> On Wed, Oct 16, 2019 at 05:21:31PM +0800, YueHaibing wrote:
>> Use devm_platform_ioremap_resource() to simplify the code a bit.
>> This is detected by coccinelle.
> 
> Adding the module author and others. I can't see a reason to not do
> this.

yes. Looks good to me.

Reviewed-by: Cédric Le Goater <clg@...d.org>

Thanks,

C.

> -corey
> 
>>
>> Signed-off-by: YueHaibing <yuehaibing@...wei.com>
>> ---
>>  drivers/char/ipmi/bt-bmc.c | 4 +---
>>  1 file changed, 1 insertion(+), 3 deletions(-)
>>
>> diff --git a/drivers/char/ipmi/bt-bmc.c b/drivers/char/ipmi/bt-bmc.c
>> index 40b9927..d36aeac 100644
>> --- a/drivers/char/ipmi/bt-bmc.c
>> +++ b/drivers/char/ipmi/bt-bmc.c
>> @@ -444,15 +444,13 @@ static int bt_bmc_probe(struct platform_device *pdev)
>>  
>>  	bt_bmc->map = syscon_node_to_regmap(pdev->dev.parent->of_node);
>>  	if (IS_ERR(bt_bmc->map)) {
>> -		struct resource *res;
>>  		void __iomem *base;
>>  
>>  		/*
>>  		 * Assume it's not the MFD-based devicetree description, in
>>  		 * which case generate a regmap ourselves
>>  		 */
>> -		res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
>> -		base = devm_ioremap_resource(&pdev->dev, res);
>> +		base = devm_platform_ioremap_resource(pdev, 0);
>>  		if (IS_ERR(base))
>>  			return PTR_ERR(base);
>>  
>> -- 
>> 2.7.4
>>
>>