linux-kernel - Re: [PATCH -next v3] arm64: mm: Fix unused variable warning in zone_sizes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20191016155154.GA55959@ubuntu-m2-xlarge-x86>
Date:   Wed, 16 Oct 2019 08:51:54 -0700
From:   Nathan Chancellor <natechancellor@...il.com>
To:     Nicolas Saenz Julienne <nsaenzjulienne@...e.de>
Cc:     Catalin Marinas <catalin.marinas@....com>,
        Will Deacon <will@...nel.org>,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH -next v3] arm64: mm: Fix unused variable warning in
 zone_sizes_init

On Wed, Oct 16, 2019 at 05:09:30PM +0200, Nicolas Saenz Julienne wrote:
> On Wed, 2019-10-16 at 16:08 +0100, Catalin Marinas wrote:
> > On Wed, Oct 16, 2019 at 07:47:14AM -0700, Nathan Chancellor wrote:
> > > When building arm64 allnoconfig, CONFIG_ZONE_DMA and CONFIG_ZONE_DMA32
> > > get disabled so there is a warning about max_dma being unused.
> > > 
> > > ../arch/arm64/mm/init.c:215:16: warning: unused variable 'max_dma'
> > > [-Wunused-variable]
> > >         unsigned long max_dma = min;
> > >                       ^
> > > 1 warning generated.
> > > 
> > > Add __maybe_unused to make this clear to the compiler.
> > > 
> > > Fixes: 1a8e1cef7603 ("arm64: use both ZONE_DMA and ZONE_DMA32")
> > > Signed-off-by: Nathan Chancellor <natechancellor@...il.com>
> > 
> > Thanks. Queued on top of Nicolas' patches for 5.5. I also added Nicolas'
> > reviewed-by from v2 as I suspect it still stands.
> 
> Yes, thanks!
> 

Thank you both for reviewing the patch and picking it up!

Cheers,
Nathan