linux-kernel - Re: [PATCH] NFSv4: add declaration of current

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <63bbd39b-6f9d-f58c-4ad7-428ac4ca9d5b@codethink.co.uk>
Date:   Wed, 16 Oct 2019 17:27:00 +0100
From:   Ben Dooks <ben.dooks@...ethink.co.uk>
To:     Christoph Hellwig <hch@...radead.org>
Cc:     linux-kernel@...ts.codethink.co.uk,
        Trond Myklebust <trond.myklebust@...merspace.com>,
        Anna Schumaker <anna.schumaker@...app.com>,
        linux-nfs@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] NFSv4: add declaration of current_stateid

On 15/10/2019 17:31, Christoph Hellwig wrote:
> On Tue, Oct 15, 2019 at 01:19:53PM +0100, Ben Dooks wrote:
>> The current_stateid is exported from nfs4state.c but not
>> declared in any of the headers. Add to nfs4_fs.h to
>> remove the following warning:
> 
> I think you also need to remove the extern in pnfs.c as well.

ok, thanks, will sort.

> Also nfs4_stateid_is_current has a local variable with the same name,
> so you might want to rename that so that we don't get symbol shadowing
> warnings.
> 
ok, will do.

-- 
Ben Dooks				http://www.codethink.co.uk/
Senior Engineer				Codethink - Providing Genius

https://www.codethink.co.uk/privacy.html