linux-kernel - Re: [PATCH] hugetlb: Fix clang compilation warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <cac7143d-fc2e-16c5-c422-42b06acf7039@arm.com>
Date:   Wed, 16 Oct 2019 17:41:02 +0100
From:   Vincenzo Frascino <vincenzo.frascino@....com>
To:     Mike Kravetz <mike.kravetz@...cle.com>, linux-mm@...ck.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] hugetlb: Fix clang compilation warning

Hi Mike,

On 10/16/19 4:21 PM, Mike Kravetz wrote:
> On 10/16/19 7:23 AM, Vincenzo Frascino wrote:
>> Building the kernel with a recent version of clang I noticed the warning
>> below:
>>
>> mm/hugetlb.c:4055:40: warning: expression does not compute the number of
>> elements in this array; element type is 'unsigned long', not 'u32'
>> (aka 'unsigned int') [-Wsizeof-array-div]
>>         hash = jhash2((u32 *)&key, sizeof(key)/sizeof(u32), 0);
>>                                           ~~~ ^
>> mm/hugetlb.c:4049:16: note: array 'key' declared here
>>         unsigned long key[2];
>>                       ^
>> mm/hugetlb.c:4055:40: note: place parentheses around the 'sizeof(u32)'
>> expression to silence this warning
>>         hash = jhash2((u32 *)&key, sizeof(key)/sizeof(u32), 0);
>>                                               ^  CC      fs/ext4/ialloc.o
>>
>> Fix the warning adding parentheses around the sizeof(u32) expression.
>>
>> Cc: Mike Kravetz <mike.kravetz@...cle.com>
>> Signed-off-by: Vincenzo Frascino <vincenzo.frascino@....com>
> 
> Thanks,
> 
> However, this is already addressed in Andrew's tree.
> https://ozlabs.org/~akpm/mmotm/broken-out/hugetlbfs-hugetlb_fault_mutex_hash-cleanup.patch
> 

Thank you for pointing this out.

-- 
Regards,
Vincenzo