linux-kernel - Re: [PATCH] iommu/vt-d: Return the correct dma mask when we are bypassing the IOMMU

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20191016191551.GA2692557@rani>
Date:   Wed, 16 Oct 2019 15:15:52 -0400
From:   Arvind Sankar <nivedita@...m.mit.edu>
To:     Lu Baolu <baolu.lu@...ux.intel.com>
Cc:     Arvind Sankar <nivedita@...m.mit.edu>,
        linux-kernel@...r.kernel.org, Christoph Hellwig <hch@....de>
Subject: Re: [PATCH] iommu/vt-d: Return the correct dma mask when we are
 bypassing the IOMMU

On Thu, Oct 10, 2019 at 09:26:37AM +0800, Lu Baolu wrote:
> Hi,
> 
> On 10/8/19 10:33 PM, Arvind Sankar wrote:
> > We must return a mask covering the full physical RAM when bypassing the
> > IOMMU mapping. Also, in iommu_need_mapping, we need to check using
> > dma_direct_get_required_mask to ensure that the device's dma_mask can
> > cover physical RAM before deciding to bypass IOMMU mapping.
> > 
> > Fixes: 249baa547901 ("dma-mapping: provide a better default ->get_required_mask")
> > Reported-by: Arvind Sankar <nivedita@...m.mit.edu>
> > Tested-by: Arvind Sankar <nivedita@...m.mit.edu>
> > Originally-by: Christoph Hellwig <hch@....de>
> > Signed-off-by: Christoph Hellwig <hch@....de>
> > Fixed-by: Arvind Sankar <nivedita@...m.mit.edu>
> > Signed-off-by: Arvind Sankar <nivedita@...m.mit.edu>
> 
> This patch looks good to me.
> 
> Reviewed-by: Lu Baolu <baolu.lu@...ux.intel.com>
> 

Hi Christoph, will you be taking this through your dma-mapping branch?

Thanks.