linux-kernel - Re: [PATCH v1 2/3] tty: serial: lpuart: Use defines that correspond to correct register

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8512c4712d0500c1c46186c2b52a7350@agner.ch>
Date:   Wed, 16 Oct 2019 22:22:18 +0200
From:   Stefan Agner <stefan@...er.ch>
To:     Philippe Schenker <philippe.schenker@...adex.com>
Cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        linux-serial@...r.kernel.org,
        Max Krummenacher <max.krummenacher@...adex.com>,
        Jiri Slaby <jslaby@...e.com>, linux-kernel@...r.kernel.org,
        Fugang Duan <fugang.duan@....com>, linux-imx@....com,
        Andrey Smirnov <andrew.smirnov@...il.com>
Subject: Re: [PATCH v1 2/3] tty: serial: lpuart: Use defines that correspond
 to correct register

On 2019-10-16 17:18, Philippe Schenker wrote:
> Use UARTMODIR defines instead of UARTMODEM as it is a 32-bit function

This reads a bit strange at first. Also it is helpful for later to state
that this does not make a difference in practise, so how about:

Use define from the 32-bit register description UARTMODIR_* instead of
UARTMODEM_*. The value is the same, so there is no functional change.

Otherwise looks good to me:

Reviewed-by: Stefan Agner <stefan.agner@...adex.com>

--
Stefan

> 
> Signed-off-by: Philippe Schenker <philippe.schenker@...adex.com>
> ---
> 
>  drivers/tty/serial/fsl_lpuart.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/tty/serial/fsl_lpuart.c b/drivers/tty/serial/fsl_lpuart.c
> index f3271857621c..346b4a070ce9 100644
> --- a/drivers/tty/serial/fsl_lpuart.c
> +++ b/drivers/tty/serial/fsl_lpuart.c
> @@ -1879,10 +1879,10 @@ lpuart32_set_termios(struct uart_port *port,
> struct ktermios *termios,
>  	}
>  
>  	if (termios->c_cflag & CRTSCTS) {
> -		modem |= UARTMODEM_RXRTSE | UARTMODEM_TXCTSE;
> +		modem |= (UARTMODIR_RXRTSE | UARTMODIR_TXCTSE);
>  	} else {
>  		termios->c_cflag &= ~CRTSCTS;
> -		modem &= ~(UARTMODEM_RXRTSE | UARTMODEM_TXCTSE);
> +		modem &= ~(UARTMODIR_RXRTSE | UARTMODIR_TXCTSE);
>  	}
>  
>  	if (termios->c_cflag & CSTOPB)