linux-kernel - Re: [PATCH v3 2/3] selftests/livepatch: Make dynamic debug setup and restore generic

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5def9a66-1029-e963-b44d-020791763f16@redhat.com>
Date:   Wed, 16 Oct 2019 17:39:17 -0400
From:   Joe Lawrence <joe.lawrence@...hat.com>
To:     Kamalesh Babulal <kamalesh@...ux.vnet.ibm.com>,
        Miroslav Benes <mbenes@...e.cz>, rostedt@...dmis.org,
        mingo@...hat.com, jpoimboe@...hat.com, jikos@...nel.org,
        pmladek@...e.com
Cc:     linux-kernel@...r.kernel.org, live-patching@...r.kernel.org,
        shuah@...nel.org, linux-kselftest@...r.kernel.org
Subject: Re: [PATCH v3 2/3] selftests/livepatch: Make dynamic debug setup and
 restore generic

On 10/16/19 1:10 PM, Kamalesh Babulal wrote:
> On 10/16/19 5:03 PM, Miroslav Benes wrote:
>> From: Joe Lawrence <joe.lawrence@...hat.com>
>>
>> Livepatch selftests currently save the current dynamic debug config and
>> tweak it for the selftests. The config is restored at the end. Make the
>> infrastructure generic, so that more variables can be saved and
>> restored.
>>
>> Signed-off-by: Joe Lawrence <joe.lawrence@...hat.com>
>> Signed-off-by: Miroslav Benes <mbenes@...e.cz>
>> ---
>>   .../testing/selftests/livepatch/functions.sh  | 22 +++++++++++--------
>>   .../selftests/livepatch/test-callbacks.sh     |  2 +-
>>   .../selftests/livepatch/test-livepatch.sh     |  2 +-
>>   .../selftests/livepatch/test-shadow-vars.sh   |  2 +-
> 
> A minor nit pick, should the README also updated with the setup_config()?
> 

Yup, good eye.  I think it should be a simple matter of 
s/set_dynamic_debug/setup_config/g

-- Joe