linux-kernel - Re: [PATCH 4/7] rcu: remove the declaration of call

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20191016034711.GZ2689@paulmck-ThinkPad-P72>
Date:   Tue, 15 Oct 2019 20:47:11 -0700
From:   "Paul E. McKenney" <paulmck@...nel.org>
To:     20191015102402.1978-1-laijs@...ux.alibaba.com
Cc:     linux-kernel@...r.kernel.org,
        Lai Jiangshan <laijs@...ux.alibaba.com>,
        Lai Jiangshan <jiangshanlai@...il.com>,
        Josh Triplett <josh@...htriplett.org>,
        Steven Rostedt <rostedt@...dmis.org>,
        Mathieu Desnoyers <mathieu.desnoyers@...icios.com>,
        Joel Fernandes <joel@...lfernandes.org>, rcu@...r.kernel.org
Subject: Re: [PATCH 4/7] rcu: remove the declaration of call_rcu() in tree.h

On Tue, Oct 15, 2019 at 10:28:46AM +0000, Lai Jiangshan wrote:
> call_rcu() is external RCU API declared in include/linux/,
> and doesn't need to be (re-)declared in internal files again.
> 
> Signed-off-by: Lai Jiangshan <jiangshanlai@...il.com>
> Signed-off-by: Lai Jiangshan <laijs@...ux.alibaba.com>

Good catch!

Queued for testing and review, thank you!

							Thanx, Paul

> ---
>  kernel/rcu/tree.h | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/kernel/rcu/tree.h b/kernel/rcu/tree.h
> index f8e6c70cceef..823f475c5e35 100644
> --- a/kernel/rcu/tree.h
> +++ b/kernel/rcu/tree.h
> @@ -412,7 +412,6 @@ static bool rcu_preempt_has_tasks(struct rcu_node *rnp);
>  static int rcu_print_task_exp_stall(struct rcu_node *rnp);
>  static void rcu_preempt_check_blocked_tasks(struct rcu_node *rnp);
>  static void rcu_flavor_sched_clock_irq(int user);
> -void call_rcu(struct rcu_head *head, rcu_callback_t func);
>  static void dump_blkd_tasks(struct rcu_node *rnp, int ncheck);
>  static void rcu_initiate_boost(struct rcu_node *rnp, unsigned long flags);
>  static void rcu_preempt_boost_start_gp(struct rcu_node *rnp);
> -- 
> 2.20.1
>