linux-kernel - Re: [PATCH] net: usb: sr9800: fix uninitialized local variable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20191015.210249.78012402045984501.davem@davemloft.net>
Date:   Tue, 15 Oct 2019 21:02:49 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     vvidic@...entin-vidic.from.hr
Cc:     hslester96@...il.com, linux-usb@...r.kernel.org,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
        syzbot+f1842130bbcfb335bac1@...kaller.appspotmail.com
Subject: Re: [PATCH] net: usb: sr9800: fix uninitialized local variable

From: Valentin Vidic <vvidic@...entin-vidic.from.hr>
Date: Tue, 15 Oct 2019 22:20:20 +0200

> Make sure res does not contain random value if the call to
> sr_read_cmd fails for some reason.
> 
> Reported-by: syzbot+f1842130bbcfb335bac1@...kaller.appspotmail.com
> Signed-off-by: Valentin Vidic <vvidic@...entin-vidic.from.hr>

Applied.

But often in situation like this a failed read can more aptly be indicated by
an all-1's value.