linux-kernel - Re: [PATCH] [V2] PCI: sysfs: remove pci_bridge_groups and pcie_dev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20191016221757.GA90897@google.com>
Date:   Wed, 16 Oct 2019 17:17:57 -0500
From:   Bjorn Helgaas <helgaas@...nel.org>
To:     "Ben Dooks (Codethink)" <ben.dooks@...ethink.co.uk>
Cc:     linux-kernel@...ts.codethink.co.uk, linux-pci@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] [V2] PCI: sysfs: remove pci_bridge_groups and
 pcie_dev_groups

On Wed, Oct 16, 2019 at 09:03:24AM +0100, Ben Dooks (Codethink) wrote:
> From: Ben Dooks <ben.dooks@...ethink.co.uk>
> 
> The pci_bridge_groups and pcie_dev_groups objects are
> not exported and not used at-all, so remove them to
> fix the following warnings from sparse:
> 
> drivers/pci/pci-sysfs.c:1546:30: warning: symbol 'pci_bridge_groups' was not declared. Should it be static?
> drivers/pci/pci-sysfs.c:1555:30: warning: symbol 'pcie_dev_groups' was not declared. Should it be static?
> 
> Also remove the unused pci_bridge_group and pcie_dev_group
> as they are not used any more.
> 
> Signed-off-by: Ben Dooks <ben.dooks@...ethink.co.uk>

Applied to pci/misc for v5.5, thanks a lot, Ben!

> ---
> Cc: Bjorn Helgaas <bhelgaas@...gle.com>
> Cc: linux-pci@...r.kernel.org
> Cc: linux-kernel@...r.kernel.org
> 
> fixup - more unused pci bits
> ---
>  drivers/pci/pci-sysfs.c | 18 ------------------
>  1 file changed, 18 deletions(-)
> 
> diff --git a/drivers/pci/pci-sysfs.c b/drivers/pci/pci-sysfs.c
> index 793412954529..eaffb477c5bf 100644
> --- a/drivers/pci/pci-sysfs.c
> +++ b/drivers/pci/pci-sysfs.c
> @@ -1539,24 +1539,6 @@ const struct attribute_group *pci_dev_groups[] = {
>  	NULL,
>  };
>  
> -static const struct attribute_group pci_bridge_group = {
> -	.attrs = pci_bridge_attrs,
> -};
> -
> -const struct attribute_group *pci_bridge_groups[] = {
> -	&pci_bridge_group,
> -	NULL,
> -};
> -
> -static const struct attribute_group pcie_dev_group = {
> -	.attrs = pcie_dev_attrs,
> -};
> -
> -const struct attribute_group *pcie_dev_groups[] = {
> -	&pcie_dev_group,
> -	NULL,
> -};
> -
>  static const struct attribute_group pci_dev_hp_attr_group = {
>  	.attrs = pci_dev_hp_attrs,
>  	.is_visible = pci_dev_hp_attrs_are_visible,
> -- 
> 2.23.0
>