linux-kernel - Re: [PATCH 5.3 112/112] ASoC: sgtl5000: add ADC mute control

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 16 Oct 2019 16:23:58 -0700
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     Mark Brown <broonie@...nel.org>
Cc:     Richard Leitner <richard.leitner@...data.com>,
        linux-kernel@...r.kernel.org, stable@...r.kernel.org,
        Oleksandr Suvorov <oleksandr.suvorov@...adex.com>,
        Marcel Ziswiler <marcel.ziswiler@...adex.com>,
        Igor Opaniuk <igor.opaniuk@...adex.com>,
        Fabio Estevam <festevam@...il.com>
Subject: Re: [PATCH 5.3 112/112] ASoC: sgtl5000: add ADC mute control

On Wed, Oct 16, 2019 at 11:35:18PM +0100, Mark Brown wrote:
> On Wed, Oct 16, 2019 at 03:10:25PM -0700, Greg Kroah-Hartman wrote:
> > On Wed, Oct 16, 2019 at 11:00:44PM +0100, Mark Brown wrote:
> > > On Wed, Oct 16, 2019 at 02:51:44PM -0700, Greg Kroah-Hartman wrote:
> > > > From: Oleksandr Suvorov <oleksandr.suvorov@...adex.com>
> 
> > > > commit 694b14554d75f2a1ae111202e71860d58b434a21 upstream.
> 
> > > > This control mute/unmute the ADC input of SGTL5000
> > > > using its CHIP_ANA_CTRL register.
> 
> > > This seems like a new feature and not an obvious candidate for stable?
> 
> > there was a long email from Richard that said:
> > 	Upstream commit 631bc8f0134a ("ASoC: sgtl5000: Fix of unmute
> > 	outputs on probe"), which is e9f621efaebd in v5.3 replaced
> > 	snd_soc_component_write with snd_soc_component_update_bits and
> > 	therefore no longer cleared the MUTE_ADC flag. This caused the
> > 	ADC to stay muted and recording doesn't work any longer. This
> > 	patch fixes this problem by adding a Switch control for
> > 	MUTE_ADC.
> 
> > That's why I took this.  If this isn't true, I'll be glad to drop this.
> 
> That's probably not an appropriate fix for stable - it's going to add a
> new control which users will need to manually set (or hope their
> userspace automatically figures out that it should set for them, more
> advanced userspaces like PulseAudio should) which isn't a drop in fix. 
> You could either drop the backport that was done for zero cross or take
> a new patch that clears the MUTE_ADC flag (rather than punting to
> userspace to do so), or just be OK with what you've got at the minute
> which might be fine given the lack of user reports.

Ok, I'll gladly go drop it, thanks!

greg k-h