linux-kernel - Re: [PATCH] ASoC: rsnd: Reinitialize bit clock inversion flag for every format setting

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <878spkuu5o.wl-kuninori.morimoto.gx@renesas.com>
Date:   17 Oct 2019 08:50:54 +0900
From:   Kuninori Morimoto <kuninori.morimoto.gx@...esas.com>
To:     Eugeniu Rosca <erosca@...adit-jv.com>
Cc:     Linux-Renesas <linux-renesas-soc@...r.kernel.org>,
        Takashi Iwai <tiwai@...e.com>,
        Jaroslav Kysela <perex@...ex.cz>,
        Mark Brown <broonie@...nel.org>,
        Liam Girdwood <lgirdwood@...il.com>,
        <linux-kernel@...r.kernel.org>, <alsa-devel@...a-project.org>,
        Eugeniu Rosca <roscaeugeniu@...il.com>,
        Junya Monden <jmonden@...adit-jv.com>,
        Andrew Gabbasov <andrew_gabbasov@...tor.com>,
        Jiada Wang <jiada_wang@...tor.com>,
        Timo Wischer <twischer@...adit-jv.com>,
        <stable@...r.kernel.org>
Subject: Re: [PATCH] ASoC: rsnd: Reinitialize bit clock inversion flag for every format setting


Hi

> Unlike other format-related DAI parameters, rdai->bit_clk_inv flag
> is not properly re-initialized when setting format for new stream
> processing. The inversion, if requested, is then applied not to default,
> but to a previous value, which leads to SCKP bit in SSICR register being
> set incorrectly.
> Fix this by re-setting the flag to its initial value, determined by format.
> 
> Fixes: 1a7889ca8aba3 ("ASoC: rsnd: fixup SND_SOC_DAIFMT_xB_xF behavior")
> Cc: Andrew Gabbasov <andrew_gabbasov@...tor.com>
> Cc: Jiada Wang <jiada_wang@...tor.com>
> Cc: Timo Wischer <twischer@...adit-jv.com>
> Cc: stable@...r.kernel.org # v3.17+
> Signed-off-by: Junya Monden <jmonden@...adit-jv.com>
> Signed-off-by: Eugeniu Rosca <erosca@...adit-jv.com>
> ---

Acked-by: Kuninori Morimoto <kuninori.morimoto.gx@...esas.com>