linux-kernel - RE: [PATCH -next] usb: typec: add dependency for TYPEC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <OSBPR01MB2103364C0A4E7150C10DC624B8920@OSBPR01MB2103.jpnprd01.prod.outlook.com>
Date:   Wed, 16 Oct 2019 06:39:09 +0000
From:   Biju Das <biju.das@...renesas.com>
To:     maowenan <maowenan@...wei.com>,
        "heikki.krogerus@...ux.intel.com" <heikki.krogerus@...ux.intel.com>,
        "gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>
CC:     "linux-usb@...r.kernel.org" <linux-usb@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "kernel-janitors@...r.kernel.org" <kernel-janitors@...r.kernel.org>,
        Hulk Robot <hulkci@...wei.com>
Subject: RE: [PATCH -next] usb: typec: add dependency for TYPEC_HD3SS3220


 This patch is present in both usb-next and Linux-next.

https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git/commit/?h=usb-next&id=da4b5d18dd949abdda7c8ea76c9483b5edd49616

https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?h=next-20191016&id=da4b5d18dd949abdda7c8ea76c9483b5edd49616

Cheers,
Biju


> Subject: Re: [PATCH -next] usb: typec: add dependency for
> TYPEC_HD3SS3220
> 
> kindly ping.
> 
> On 2019/10/9 9:47, Mao Wenan wrote:
> > If CONFIG_TYPEC_HD3SS3220=y, CONFIG_USB_ROLE_SWITCH=m, below
> errors
> > can be found:
> > drivers/usb/typec/hd3ss3220.o: In function `hd3ss3220_remove':
> > hd3ss3220.c:(.text+0x64): undefined reference to `usb_role_switch_put'
> > drivers/usb/typec/hd3ss3220.o: In function `hd3ss3220_dr_set':
> > hd3ss3220.c:(.text+0x154): undefined reference to
> `usb_role_switch_set_role'
> > drivers/usb/typec/hd3ss3220.o: In function `hd3ss3220_set_role':
> > hd3ss3220.c:(.text+0x294): undefined reference to
> `usb_role_switch_set_role'
> > hd3ss3220.c:(.text+0x2f4): undefined reference to
> `usb_role_switch_set_role'
> > hd3ss3220.c:(.text+0x348): undefined reference to
> `usb_role_switch_set_role'
> > hd3ss3220.c:(.text+0x390): undefined reference to
> `usb_role_switch_set_role'
> > drivers/usb/typec/hd3ss3220.o: In function `hd3ss3220_probe':
> > hd3ss3220.c:(.text+0x5e8): undefined reference to
> `fwnode_usb_role_switch_get'
> > hd3ss3220.c:(.text+0x8a4): undefined reference to `usb_role_switch_put'
> > make: *** [vmlinux] Error 1
> >
> > This patch add dependency USB_ROLE_SWITCH for TYPEC_HD3SS3220.
> >
> > Fixes: 1c48c759ef4b ("usb: typec: driver for TI HD3SS3220 USB Type-C
> > DRP port controller")
> > Reported-by: Hulk Robot <hulkci@...wei.com>
> > Signed-off-by: Mao Wenan <maowenan@...wei.com>
> > ---
> >  drivers/usb/typec/Kconfig | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/usb/typec/Kconfig b/drivers/usb/typec/Kconfig
> > index aceb2af..b4f2aac 100644
> > --- a/drivers/usb/typec/Kconfig
> > +++ b/drivers/usb/typec/Kconfig
> > @@ -53,6 +53,7 @@ source "drivers/usb/typec/ucsi/Kconfig"
> >  config TYPEC_HD3SS3220
> >  	tristate "TI HD3SS3220 Type-C DRP Port controller driver"
> >  	depends on I2C
> > +	depends on USB_ROLE_SWITCH
> >  	help
> >  	  Say Y or M here if your system has TI HD3SS3220 Type-C DRP Port
> >  	  controller driver.
> >