linux-kernel - Re: [PATCH] Revert "Input: elantech - enable SMBus on new (2018+) systems"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20191016005107.GA35946@dtor-ws>
Date:   Tue, 15 Oct 2019 17:51:07 -0700
From:   Dmitry Torokhov <dmitry.torokhov@...il.com>
To:     Benjamin Tissoires <benjamin.tissoires@...hat.com>
Cc:     Kai-Heng Feng <kai.heng.feng@...onical.com>,
        "open list:HID CORE LAYER" <linux-input@...r.kernel.org>,
        lkml <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] Revert "Input: elantech - enable SMBus on new (2018+)
 systems"

On Fri, Oct 11, 2019 at 05:26:05PM +0200, Benjamin Tissoires wrote:
> Hi Kai-Heng,
> 
> On Tue, Oct 1, 2019 at 9:09 AM Kai-Heng Feng
> <kai.heng.feng@...onical.com> wrote:
> >
> > This reverts commit 883a2a80f79ca5c0c105605fafabd1f3df99b34c.
> >
> > Apparently use dmi_get_bios_year() as manufacturing date isn't accurate
> > and this breaks older laptops with new BIOS update.
> >
> > So let's revert this patch.
> >
> > There are still new HP laptops still need to use SMBus to support all
> > features, but it'll be enabled via a whitelist.
> >
> 
> You might want to add here:
> Link: https://bugzilla.kernel.org/show_bug.cgi?id=204771
> 
> > Signed-off-by: Kai-Heng Feng <kai.heng.feng@...onical.com>
> 
> Oops, seems like you are missing my acked by:
> Acked-by: Benjamin Tissoires <benjamin.tissoires@...hat.com>
> 
> Also, don't we want to send this one to stable as well? I can't
> remember if we reverted it in all the released kernels.

It looks like we need it for 5.3 so I marked it for stable.

Thanks.

-- 
Dmitry