linux-kernel - Re: [PATCH] bus: moxtet: declare moxtet_bus

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20191016074028.GA25140@infradead.org>
Date:   Wed, 16 Oct 2019 00:40:28 -0700
From:   Christoph Hellwig <hch@...radead.org>
To:     Ben Dooks <ben.dooks@...ethink.co.uk>
Cc:     Christoph Hellwig <hch@...radead.org>,
        linux-kernel@...ts.codethink.co.uk,
        Marek Behun <marek.behun@....cz>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] bus: moxtet: declare moxtet_bus_type

On Wed, Oct 16, 2019 at 08:34:06AM +0100, Ben Dooks wrote:
> On 15/10/2019 17:32, Christoph Hellwig wrote:
> > On Tue, Oct 15, 2019 at 01:25:35PM +0100, Ben Dooks wrote:
> > > The moxtet_bus_type object is exported from the bus
> > > driver, but not declared. Add a declaration for use
> > > and to silence the following warning:
> > 
> > The symbol can be marked static instead.
> 
> Then it would have to be un-exported as it's listed as
> EXPORT_SYMBOL_GPL(moxtet_bus_type);

Yes, once you mark it static you should also remove the export.