linux-kernel - Re: drm/komeda: Dump SC_ENH_* registers from scaler block

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20191016081732.GA16502@jamwan02-TSP300>
Date:   Wed, 16 Oct 2019 08:17:39 +0000
From:   "james qian wang (Arm Technology China)" <james.qian.wang@....com>
To:     Mihail Atanassov <Mihail.Atanassov@....com>
CC:     David Airlie <airlied@...ux.ie>, Liviu Dudau <Liviu.Dudau@....com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "dri-devel@...ts.freedesktop.org" <dri-devel@...ts.freedesktop.org>,
        "Lowry Li (Arm Technology China)" <Lowry.Li@....com>,
        nd <nd@....com>, Sean Paul <sean@...rly.run>
Subject: Re: drm/komeda: Dump SC_ENH_* registers from scaler block

On Tue, Oct 15, 2019 at 11:00:01AM +0000, Mihail Atanassov wrote:
> Signed-off-by: Mihail Atanassov <mihail.atanassov@....com>
> ---
>  .../gpu/drm/arm/display/komeda/d71/d71_component.c | 14 +++++++++++++-
>  1 file changed, 13 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/arm/display/komeda/d71/d71_component.c b/drivers/gpu/drm/arm/display/komeda/d71/d71_component.c
> index c3d29c0b051b..7252fc387fba 100644
> --- a/drivers/gpu/drm/arm/display/komeda/d71/d71_component.c
> +++ b/drivers/gpu/drm/arm/display/komeda/d71/d71_component.c
> @@ -703,7 +703,7 @@ static void d71_scaler_update(struct komeda_component *c,
>  
>  static void d71_scaler_dump(struct komeda_component *c, struct seq_file *sf)
>  {
> -	u32 v[9];
> +	u32 v[10];
>  
>  	dump_block_header(sf, c->reg);
>  
> @@ -723,6 +723,18 @@ static void d71_scaler_dump(struct komeda_component *c, struct seq_file *sf)
>  	seq_printf(sf, "SC_H_DELTA_PH:\t\t0x%X\n", v[6]);
>  	seq_printf(sf, "SC_V_INIT_PH:\t\t0x%X\n", v[7]);
>  	seq_printf(sf, "SC_V_DELTA_PH:\t\t0x%X\n", v[8]);
> +
> +	get_values_from_reg(c->reg, 0x130, 10, v);
> +	seq_printf(sf, "SC_ENH_LIMITS:\t\t0x%X\n", v[0]);
> +	seq_printf(sf, "SC_ENH_COEFF0:\t\t0x%X\n", v[1]);
> +	seq_printf(sf, "SC_ENH_COEFF1:\t\t0x%X\n", v[2]);
> +	seq_printf(sf, "SC_ENH_COEFF2:\t\t0x%X\n", v[3]);
> +	seq_printf(sf, "SC_ENH_COEFF3:\t\t0x%X\n", v[4]);
> +	seq_printf(sf, "SC_ENH_COEFF4:\t\t0x%X\n", v[5]);
> +	seq_printf(sf, "SC_ENH_COEFF5:\t\t0x%X\n", v[6]);
> +	seq_printf(sf, "SC_ENH_COEFF6:\t\t0x%X\n", v[7]);
> +	seq_printf(sf, "SC_ENH_COEFF7:\t\t0x%X\n", v[8]);
> +	seq_printf(sf, "SC_ENH_COEFF8:\t\t0x%X\n", v[9]);
>  }
>

Looks good to me.

Reviewed-by: James Qian Wang (Arm Technology China) <james.qian.wang@....com>

>  static const struct komeda_component_funcs d71_scaler_funcs = {