[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20191016135653.GB17013@lunn.ch>
Date: Wed, 16 Oct 2019 15:56:53 +0200
From: Andrew Lunn <andrew@...n.ch>
To: Florian Fainelli <f.fainelli@...il.com>
Cc: netdev@...r.kernel.org, "David S. Miller" <davem@...emloft.net>,
open list <linux-kernel@...r.kernel.org>, hkallweit1@...il.com,
bcm-kernel-feedback-list@...adcom.com, olteanv@...il.com,
rmk+kernel@...linux.org.uk, cphealy@...il.com,
Jose Abreu <joabreu@...opsys.com>
Subject: Re: [PATCH net-next 1/2] net: phy: Use genphy_loopback() by default
On Tue, Oct 15, 2019 at 03:49:52PM -0700, Florian Fainelli wrote:
> The standard way of putting a PHY device into loopback is most often
> suitable for testing. This is going to be necessary in a subsequent
> patch that adds RGII debugging capability using the loopback feature.
>
> Signed-off-by: Florian Fainelli <f.fainelli@...il.com>
> ---
> drivers/net/phy/phy_device.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/phy/phy_device.c b/drivers/net/phy/phy_device.c
> index 9d2bbb13293e..c2e66b9ec161 100644
> --- a/drivers/net/phy/phy_device.c
> +++ b/drivers/net/phy/phy_device.c
> @@ -1514,7 +1514,7 @@ int phy_loopback(struct phy_device *phydev, bool enable)
> if (phydev->drv && phydrv->set_loopback)
> ret = phydrv->set_loopback(phydev, enable);
> else
> - ret = -EOPNOTSUPP;
> + ret = genphy_loopback(phydev, enable);
Hi Florian
I think you need to differentiate between C22 and C45 somewhere.
Andrew
Powered by blists - more mailing lists