linux-kernel - Re: [PATCH v3] PCI: dwc: Add support to add GEN3 related equalization quirks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <SL2P216MB010526CC784E2F4364B4197DAA920@SL2P216MB0105.KORP216.PROD.OUTLOOK.COM>
Date:   Wed, 16 Oct 2019 14:44:12 +0000
From:   Jingoo Han <jingoohan1@...il.com>
To:     'Christoph Hellwig' <hch@...radead.org>,
        Pankaj Dubey <pankaj.dubey@...sung.com>
CC:     "linux-pci@...r.kernel.org" <linux-pci@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "bhelgaas@...gle.com" <bhelgaas@...gle.com>,
        "andrew.murray@....com" <andrew.murray@....com>,
        "lorenzo.pieralisi@....com" <lorenzo.pieralisi@....com>,
        "gustavo.pimentel@...opsys.com" <gustavo.pimentel@...opsys.com>,
        "vidyas@...dia.com" <vidyas@...dia.com>,
        'Anvesh Salveru' <anvesh.s@...sung.com>,
        Han Jingoo <jingoohan1@...il.com>
Subject: Re: [PATCH v3] PCI: dwc: Add support to add GEN3 related equalization
 quirks

On 10/16/19, 2:52 AM, 'Christoph Hellwig' wrote:
>
> On Tue, Oct 15, 2019 at 08:47:32PM +0530, Pankaj Dubey wrote:
> > OK, but do we think the current driver has only code which is being used by
> > some user?
>
> That is at least the intent of how we do kernel development. 

Agreed!

>
> > At least I can see current driver has some features which is not being used
> > by any current driver.  
>
> Please send patches to remove them.

Agreed!

Mainline kernel should not include features that have not been used.
Thank you.

Best regards,
Jingoo Han