[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20191016145208.dqvquyw2m4o5skbz@pathway.suse.cz>
Date: Wed, 16 Oct 2019 16:52:08 +0200
From: Petr Mladek <pmladek@...e.com>
To: Andy Shevchenko <andy.shevchenko@...il.com>
Cc: Rasmus Villemoes <linux@...musvillemoes.dk>,
Uwe Kleine-König <uwe@...ine-koenig.org>,
Andrew Morton <akpm@...ux-foundation.org>,
Jonathan Corbet <corbet@....net>,
Joe Perches <joe@...ches.com>,
Linux Documentation List <linux-doc@...r.kernel.org>,
Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v5] printf: add support for printing symbolic error names
On Wed 2019-10-16 16:49:41, Andy Shevchenko wrote:
> On Tue, Oct 15, 2019 at 10:07 PM Rasmus Villemoes
> <linux@...musvillemoes.dk> wrote:
>
> > +const char *errname(int err)
> > +{
> > + const char *name = __errname(err > 0 ? err : -err);
>
> Looks like mine comment left unseen.
> What about to simple use abs(err) here?
Andy, would you want to ack the patch with this change?
I could do it when pushing the patch.
Otherwise, it looks ready to go.
Thanks everybody involved for the patience.
Best Regards,
Petr
Powered by blists - more mailing lists