lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 17 Oct 2019 08:50:15 +0800 From: tanhuazhong <tanhuazhong@...wei.com> To: Jakub Kicinski <jakub.kicinski@...ronome.com> CC: <davem@...emloft.net>, <netdev@...r.kernel.org>, <linux-kernel@...r.kernel.org>, <salil.mehta@...wei.com>, <yisen.zhuang@...wei.com>, <linuxarm@...wei.com>, Yunsheng Lin <linyunsheng@...wei.com> Subject: Re: [PATCH net-next 08/12] net: hns3: introduce ring_to_netdev() in enet module On 2019/10/17 1:10, Jakub Kicinski wrote: > On Wed, 16 Oct 2019 15:17:07 +0800, Huazhong Tan wrote: >> From: Yunsheng Lin <linyunsheng@...wei.com> >> >> There are a few places that need to access the netdev of a ring >> through ring->tqp->handle->kinfo.netdev, and ring->tqp is a struct >> which both in enet and hclge modules, it is better to use the >> struct that is only used in enet module. >> >> This patch adds the ring_to_netdev() to access the netdev of ring >> through ring->tqp_vector->napi.dev. >> >> Also, struct hns3_enet_ring is a frequently used in critical data >> path, so make it cacheline aligned as struct hns3_enet_tqp_vector. > > That part seems logically separate, should it be a separate patch? > ok, thanks. >> Signed-off-by: Yunsheng Lin <linyunsheng@...wei.com> >> Signed-off-by: Huazhong Tan <tanhuazhong@...wei.com> > >
Powered by blists - more mailing lists