[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <4ba66cc7-f8ff-05a0-cdee-e1bbba677e67@oracle.com>
Date: Thu, 17 Oct 2019 21:15:45 +0100
From: Joao Martins <joao.m.martins@...cle.com>
To: "Rafael J. Wysocki" <rafael@...nel.org>,
Zhenzhong Duan <zhenzhong.duan@...cle.com>
Cc: Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
"Rafael J. Wysocki" <rjw@...ysocki.net>,
Daniel Lezcano <daniel.lezcano@...aro.org>,
Linux PM <linux-pm@...r.kernel.org>,
Marcelo Tosatti <mtosatti@...hat.com>
Subject: Re: [PATCH] cpuidle-haltpoll: make haltpoll aware of 'idle=' override
On 10/17/19 8:20 PM, Rafael J. Wysocki wrote:
> On Thu, Oct 17, 2019 at 2:41 AM Zhenzhong Duan
> <zhenzhong.duan@...cle.com> wrote:
>> and haltpoll
>> is built in. If haltpoll is built as a module, still give a chance for
>> admin to use it despite 'idle='.
>
> Why exactly? Do you have any particular use case in mind?
>
There was no concrete use-case in particular; we thought that when building as a
module, that the general usage would be for cpuidle-haltpoll to be inserted (or
removed) at some point in the time. And hence allow it to override boot 'idle='
given that you can always remove the module and go back to 'idle='.
> Otherwise I'd prefer the behavior to be consistent regardless of
> whether or not it is a module..
>
It's best we just remove the conditional and keep it consistent across builtin
and module.
Joao
Powered by blists - more mailing lists