linux-kernel - Re: [PATCH] ftrace: fix function type mismatches

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CABCJKue6x0KfCR1xYUrJZnnzf_yp1CidmULwvGS5a-=yRbPzCQ@mail.gmail.com>
Date:   Thu, 17 Oct 2019 14:18:20 -0700
From:   Sami Tolvanen <samitolvanen@...gle.com>
To:     Steven Rostedt <rostedt@...dmis.org>
Cc:     Kees Cook <keescook@...omium.org>, Ingo Molnar <mingo@...hat.com>,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] ftrace: fix function type mismatches

On Tue, Oct 15, 2019 at 6:01 AM Steven Rostedt <rostedt@...dmis.org> wrote:
> Would this work for you?

>  #define MCOUNT_REC()   . = ALIGN(8);                           \
>                         __start_mcount_loc = .;                 \
>                         KEEP(*(__patchable_function_entries))   \
> -                       __stop_mcount_loc = .;
> +                       __stop_mcount_loc = .;                  \
> +                       ftrace_graph_stub = ftrace_stub;

> +extern void ftrace_graph_stub(struct ftrace_graph_ret *);

Yes, it looks like the compiler is actually happy with this approach.
Thank you for the patch!

Sami