linux-kernel - RE: [EXT] [PATCH v1 2/3] tty: serial: lpuart: Use defines that correspond to correct register

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 17 Oct 2019 05:13:55 +0000
From:   Andy Duan <fugang.duan@....com>
To:     Philippe Schenker <philippe.schenker@...adex.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        "linux-serial@...r.kernel.org" <linux-serial@...r.kernel.org>
CC:     Max Krummenacher <max.krummenacher@...adex.com>,
        Jiri Slaby <jslaby@...e.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Stefan Agner <stefan@...er.ch>,
        dl-linux-imx <linux-imx@....com>,
        Andrey Smirnov <andrew.smirnov@...il.com>
Subject: RE: [EXT] [PATCH v1 2/3] tty: serial: lpuart: Use defines that
 correspond to correct register

From: Philippe Schenker <philippe.schenker@...adex.com> Sent: Wednesday, October 16, 2019 11:19 PM
> Use UARTMODIR defines instead of UARTMODEM as it is a 32-bit function
> 
> Signed-off-by: Philippe Schenker <philippe.schenker@...adex.com>

Reviewed-by: Fugang Duan <fugang.duan@....com>

> ---
> 
>  drivers/tty/serial/fsl_lpuart.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/tty/serial/fsl_lpuart.c b/drivers/tty/serial/fsl_lpuart.c index
> f3271857621c..346b4a070ce9 100644
> --- a/drivers/tty/serial/fsl_lpuart.c
> +++ b/drivers/tty/serial/fsl_lpuart.c
> @@ -1879,10 +1879,10 @@ lpuart32_set_termios(struct uart_port *port,
> struct ktermios *termios,
>         }
> 
>         if (termios->c_cflag & CRTSCTS) {
> -               modem |= UARTMODEM_RXRTSE |
> UARTMODEM_TXCTSE;
> +               modem |= (UARTMODIR_RXRTSE |
> UARTMODIR_TXCTSE);
>         } else {
>                 termios->c_cflag &= ~CRTSCTS;
> -               modem &= ~(UARTMODEM_RXRTSE |
> UARTMODEM_TXCTSE);
> +               modem &= ~(UARTMODIR_RXRTSE |
> UARTMODIR_TXCTSE);
>         }
> 
>         if (termios->c_cflag & CSTOPB)
> --
> 2.23.0