linux-kernel - RE: [PATCH] arm64: defconfig: add JFFS FS support in defconfig

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <D53702B8F0ACD34B9B1D7D82EE03C0450784EE2B@PGSMSX101.gar.corp.intel.com>
Date:   Thu, 17 Oct 2019 06:09:09 +0000
From:   "Ooi, Joyce" <joyce.ooi@...el.com>
To:     Vladimir Murzin <vladimir.murzin@....com>,
        Catalin Marinas <catalin.marinas@....com>,
        Will Deacon <will@...nel.org>,
        Dinh Nguyen <dinguyen@...nel.org>
CC:     "Tan, Ley Foon" <ley.foon.tan@...el.com>,
        Anson Huang <Anson.Huang@....com>,
        Arnd Bergmann <arnd@...db.de>,
        "Ong, Hean Loong" <hean.loong.ong@...el.com>,
        "See, Chin Liang" <chin.liang.see@...el.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Maxime Ripard <mripard@...nel.org>,
        Bjorn Andersson <bjorn.andersson@...aro.org>,
        "Marcin Juszkiewicz" <marcin.juszkiewicz@...aro.org>,
        Jagan Teki <jagan@...rulasolutions.com>,
        Olof Johansson <olof@...om.net>,
        "Leonard Crestez" <leonard.crestez@....com>,
        Shawn Guo <shawnguo@...nel.org>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>
Subject: RE: [PATCH] arm64: defconfig: add JFFS FS support in defconfig

> -----Original Message-----
> From: Vladimir Murzin [mailto:vladimir.murzin@....com]
> Sent: Wednesday, October 16, 2019 7:46 PM
> To: Ooi, Joyce <joyce.ooi@...el.com>; Catalin Marinas
> <catalin.marinas@....com>; Will Deacon <will@...nel.org>; Dinh Nguyen
> <dinguyen@...nel.org>
> Cc: Tan, Ley Foon <ley.foon.tan@...el.com>; Anson Huang
> <Anson.Huang@....com>; Arnd Bergmann <arnd@...db.de>; Ong, Hean Loong
> <hean.loong.ong@...el.com>; See, Chin Liang <chin.liang.see@...el.com>;
> linux-kernel@...r.kernel.org; Maxime Ripard <mripard@...nel.org>; Bjorn
> Andersson <bjorn.andersson@...aro.org>; Marcin Juszkiewicz
> <marcin.juszkiewicz@...aro.org>; Jagan Teki <jagan@...rulasolutions.com>;
> Olof Johansson <olof@...om.net>; Leonard Crestez
> <leonard.crestez@....com>; Shawn Guo <shawnguo@...nel.org>; linux-arm-
> kernel@...ts.infradead.org
> Subject: Re: [PATCH] arm64: defconfig: add JFFS FS support in defconfig
> 
> On 10/16/19 10:35 AM, Ooi, Joyce wrote:
> > This patch adds JFFS2 FS support and remove QSPI Sector 4K size force
> > in the default defconfig
> >
> > Signed-off-by: Ooi, Joyce <joyce.ooi@...el.com>
> > ---
> >  arch/arm64/configs/defconfig | 2 ++
> >  1 file changed, 2 insertions(+)
> >
> > diff --git a/arch/arm64/configs/defconfig
> > b/arch/arm64/configs/defconfig index c9adae4..6080c6e 100644
> > --- a/arch/arm64/configs/defconfig
> > +++ b/arch/arm64/configs/defconfig
> > @@ -860,3 +860,5 @@ CONFIG_DEBUG_KERNEL=y  #
> CONFIG_DEBUG_PREEMPT is
> > not set  # CONFIG_FTRACE is not set  CONFIG_MEMTEST=y
> > +CONFIG_JFFS2_FS=y
> > +CONFIG_MTD_SPI_NOR_USE_4K_SECTORS=n
>                                    ^^^^
> This is incorrect syntax for disabling config option. Correct one is
> 
> # CONFIG_MTD_SPI_NOR_USE_4K_SECTORS is not set
Okay, will do that.

> 
> However, it looks to me you want to remove it from defconfig rather than force
> it to be unset.
> 
> Cheers
> Vladimir