[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20191017072645.GA2778@aptenodytes>
Date: Thu, 17 Oct 2019 09:26:45 +0200
From: Paul Kocialkowski <paul.kocialkowski@...tlin.com>
To: YueHaibing <yuehaibing@...wei.com>
Cc: mripard@...nel.org, mchehab@...nel.org, gregkh@...uxfoundation.org,
wens@...e.org, linux-media@...r.kernel.org,
devel@...verdev.osuosl.org, linux-arm-kernel@...ts.infradead.org,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH -next] staging: media: cedrus: use
devm_platform_ioremap_resource() to simplify code
Hi,
On Wed 16 Oct 19, 16:56, YueHaibing wrote:
> Use devm_platform_ioremap_resource() to simplify the code a bit.
> This is detected by coccinelle.
This is still:
Acked-by: Paul Kocialkowski <paul.kocialkowski@...tlin.com>
Please collect the tag in your next version, if there's a need for one.
Cheers,
Paul
> Signed-off-by: YueHaibing <yuehaibing@...wei.com>
> ---
> drivers/staging/media/sunxi/cedrus/cedrus_hw.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/staging/media/sunxi/cedrus/cedrus_hw.c b/drivers/staging/media/sunxi/cedrus/cedrus_hw.c
> index a942cd9..f19b87c 100644
> --- a/drivers/staging/media/sunxi/cedrus/cedrus_hw.c
> +++ b/drivers/staging/media/sunxi/cedrus/cedrus_hw.c
> @@ -146,7 +146,6 @@ static irqreturn_t cedrus_irq(int irq, void *data)
> int cedrus_hw_probe(struct cedrus_dev *dev)
> {
> const struct cedrus_variant *variant;
> - struct resource *res;
> int irq_dec;
> int ret;
>
> @@ -225,8 +224,7 @@ int cedrus_hw_probe(struct cedrus_dev *dev)
> goto err_sram;
> }
>
> - res = platform_get_resource(dev->pdev, IORESOURCE_MEM, 0);
> - dev->base = devm_ioremap_resource(dev->dev, res);
> + dev->base = devm_platform_ioremap_resource(dev->pdev, 0);
> if (IS_ERR(dev->base)) {
> dev_err(dev->dev, "Failed to map registers\n");
>
> --
> 2.7.4
>
>
--
Paul Kocialkowski, Bootlin
Embedded Linux and kernel engineering
https://bootlin.com
Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)
Powered by blists - more mailing lists