linux-kernel - Re: [PATCH v1 2/3] tty: serial: lpuart: Use defines that correspond to correct register

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <543cd256f408a175c734c7be5b5210839bc33b49.camel@toradex.com>
Date:   Thu, 17 Oct 2019 08:09:20 +0000
From:   Philippe Schenker <philippe.schenker@...adex.com>
To:     "stefan@...er.ch" <stefan@...er.ch>
CC:     Max Krummenacher <max.krummenacher@...adex.com>,
        "andrew.smirnov@...il.com" <andrew.smirnov@...il.com>,
        "gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>,
        "fugang.duan@....com" <fugang.duan@....com>,
        "linux-imx@....com" <linux-imx@....com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-serial@...r.kernel.org" <linux-serial@...r.kernel.org>,
        "jslaby@...e.com" <jslaby@...e.com>
Subject: Re: [PATCH v1 2/3] tty: serial: lpuart: Use defines that correspond
 to correct register

On Wed, 2019-10-16 at 22:22 +0200, Stefan Agner wrote:
> On 2019-10-16 17:18, Philippe Schenker wrote:
> > Use UARTMODIR defines instead of UARTMODEM as it is a 32-bit
> > function
> 
> This reads a bit strange at first. Also it is helpful for later to
> state
> that this does not make a difference in practise, so how about:
> 
> Use define from the 32-bit register description UARTMODIR_* instead of
> UARTMODEM_*. The value is the same, so there is no functional change.
> 
> Otherwise looks good to me:
> 
> Reviewed-by: Stefan Agner <stefan.agner@...adex.com>

Thanks for your review and comment. And also thanks to Andy Duan for his
reviews!

You're right, I could have included that so it is clear that nothing is
changed. I will send a v2 today with your suggested commit message

Philippe

> 
> --
> Stefan
> 
> > Signed-off-by: Philippe Schenker <philippe.schenker@...adex.com>
> > ---
> > 
> >  drivers/tty/serial/fsl_lpuart.c | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> > 
> > diff --git a/drivers/tty/serial/fsl_lpuart.c
> > b/drivers/tty/serial/fsl_lpuart.c
> > index f3271857621c..346b4a070ce9 100644
> > --- a/drivers/tty/serial/fsl_lpuart.c
> > +++ b/drivers/tty/serial/fsl_lpuart.c
> > @@ -1879,10 +1879,10 @@ lpuart32_set_termios(struct uart_port *port,
> > struct ktermios *termios,
> >  	}
> >  
> >  	if (termios->c_cflag & CRTSCTS) {
> > -		modem |= UARTMODEM_RXRTSE | UARTMODEM_TXCTSE;
> > +		modem |= (UARTMODIR_RXRTSE | UARTMODIR_TXCTSE);
> >  	} else {
> >  		termios->c_cflag &= ~CRTSCTS;
> > -		modem &= ~(UARTMODEM_RXRTSE | UARTMODEM_TXCTSE);
> > +		modem &= ~(UARTMODIR_RXRTSE | UARTMODIR_TXCTSE);
> >  	}
> >  
> >  	if (termios->c_cflag & CSTOPB)