linux-kernel - Re: [PATCH] ALSA: usb-audio: Disable quirks for BOSS Katana amplifiers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <s5hftjriy1q.wl-tiwai@suse.de>
Date:   Thu, 17 Oct 2019 10:19:45 +0200
From:   Takashi Iwai <tiwai@...e.de>
To:     Szabolcs Szőke <szszoke.code@...il.com>
Cc:     <alsa-devel@...a-project.org>,
        "Manuel Reinhardt" <manuel.rhdt@...il.com>,
        "Mauro Carvalho Chehab" <mchehab+samsung@...nel.org>,
        "Shuah Khan" <shuah@...nel.org>, "Ard van Breemen" <ard@...ak.net>,
        "Thomas Gleixner" <tglx@...utronix.de>,
        "Jaroslav Kysela" <perex@...ex.cz>,
        "Richard Fontana" <rfontana@...hat.com>,
        "Takashi Iwai" <tiwai@...e.com>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] ALSA: usb-audio: Disable quirks for BOSS Katana amplifiers

On Fri, 11 Oct 2019 19:19:36 +0200,
Szabolcs Szőke wrote:
> 
> BOSS Katana amplifiers cannot be used for recording or playback if quirks
> are applied
> 
> BugLink: https://bugzilla.kernel.org/show_bug.cgi?id=195223
> Signed-off-by: Szabolcs Szőke <szszoke.code@...il.com>

Applied now.  Thanks.


Takashi

> 
> ---
>  sound/usb/pcm.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/sound/usb/pcm.c b/sound/usb/pcm.c
> index 33cd26763c0e..daadb0c66eee 100644
> --- a/sound/usb/pcm.c
> +++ b/sound/usb/pcm.c
> @@ -348,6 +348,9 @@ static int set_sync_ep_implicit_fb_quirk(struct snd_usb_substream *subs,
>  		ep = 0x84;
>  		ifnum = 0;
>  		goto add_sync_ep_from_ifnum;
> +	case USB_ID(0x0582, 0x01d8): /* BOSS Katana */
> +		/* BOSS Katana amplifiers do not need quirks */
> +		return 0;
>  	}
>  
>  	if (attr == USB_ENDPOINT_SYNC_ASYNC &&
> -- 
> 2.20.1
>