linux-kernel - Re: [PATCH] fsnotify: move declaration of fsnotify_mark_connector

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20191017083226.GB20260@quack2.suse.cz>
Date:   Thu, 17 Oct 2019 10:32:26 +0200
From:   Jan Kara <jack@...e.cz>
To:     Ben Dooks <ben.dooks@...ethink.co.uk>
Cc:     linux-kernel@...ts.codethink.co.uk, Jan Kara <jack@...e.cz>,
        Amir Goldstein <amir73il@...il.com>,
        linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] fsnotify: move declaration of
 fsnotify_mark_connector_cachep to fsnotify.h

On Tue 15-10-19 14:25:18, Ben Dooks wrote:
> Move fsnotify_mark_connector_cachep to fsnotify.h to properly
> share it with the user in mark.c and avoid the following warning
> from sparse:
> 
> fs/notify/mark.c:82:19: warning: symbol 'fsnotify_mark_connector_cachep' was not declared. Should it be static?
> 
> Signed-off-by: Ben Dooks <ben.dooks@...ethink.co.uk>

OK, fair enough. Applied. Thanks for the patch.

								Honza

> ---
> Cc: Jan Kara <jack@...e.cz>
> Cc: Amir Goldstein <amir73il@...il.com>
> Cc: linux-fsdevel@...r.kernel.org
> Cc: linux-kernel@...r.kernel.org
> ---
>  fs/notify/fsnotify.c | 2 --
>  fs/notify/fsnotify.h | 2 ++
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/fs/notify/fsnotify.c b/fs/notify/fsnotify.c
> index 2ecef6155fc0..3e77b728a22b 100644
> --- a/fs/notify/fsnotify.c
> +++ b/fs/notify/fsnotify.c
> @@ -381,8 +381,6 @@ int fsnotify(struct inode *to_tell, __u32 mask, const void *data, int data_is,
>  }
>  EXPORT_SYMBOL_GPL(fsnotify);
>  
> -extern struct kmem_cache *fsnotify_mark_connector_cachep;
> -
>  static __init int fsnotify_init(void)
>  {
>  	int ret;
> diff --git a/fs/notify/fsnotify.h b/fs/notify/fsnotify.h
> index f3462828a0e2..ff2063ec6b0f 100644
> --- a/fs/notify/fsnotify.h
> +++ b/fs/notify/fsnotify.h
> @@ -65,4 +65,6 @@ extern void __fsnotify_update_child_dentry_flags(struct inode *inode);
>  extern struct fsnotify_event_holder *fsnotify_alloc_event_holder(void);
>  extern void fsnotify_destroy_event_holder(struct fsnotify_event_holder *holder);
>  
> +extern struct kmem_cache *fsnotify_mark_connector_cachep;
> +
>  #endif	/* __FS_NOTIFY_FSNOTIFY_H_ */
> -- 
> 2.23.0
> 
-- 
Jan Kara <jack@...e.com>
SUSE Labs, CR