linux-kernel - Re: [PATCH 2/7] ASoC: amd: Registering device endpoints using MFD framework

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ca3d7434-e15e-b701-8a42-3d9eadacf227@amd.com>
Date:   Thu, 17 Oct 2019 09:26:39 +0000
From:   vishnu <vravulap@....com>
To:     Lee Jones <lee.jones@...aro.org>,
        "RAVULAPATI, VISHNU VARDHAN RAO" 
        <Vishnuvardhanrao.Ravulapati@....com>
CC:     "Deucher, Alexander" <Alexander.Deucher@....com>,
        Liam Girdwood <lgirdwood@...il.com>,
        Mark Brown <broonie@...nel.org>,
        Jaroslav Kysela <perex@...ex.cz>,
        Takashi Iwai <tiwai@...e.com>,
        "Mukunda, Vijendar" <Vijendar.Mukunda@....com>,
        Maruthi Srinivas Bayyavarapu <Maruthi.Bayyavarapu@....com>,
        "Mehta, Sanju" <Sanju.Mehta@....com>,
        Colin Ian King <colin.king@...onical.com>,
        Dan Carpenter <dan.carpenter@...cle.com>,
        "moderated list:SOUND - SOC LAYER / DYNAMIC AUDIO POWER MANAGEM..." 
        <alsa-devel@...a-project.org>,
        open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 2/7] ASoC: amd: Registering device endpoints using MFD
 framework

Hi Lee,

Okay.We will proceed with existing platform device model.

Mark,

I will resend the patches with the review comments addressed.


Thanks,
Vishnu

On 14/10/19 12:33 PM, Lee Jones wrote:
> On Thu, 10 Oct 2019, RAVULAPATI, VISHNU VARDHAN RAO wrote:
> 
>> Hi Lee,
>>
>> We have two instances BT and I2S.
>> We need to create devices with same name added with number of device
>> like example:
>> acp3x_i2s_playcap.1.auto<http://1.auto>
>> acp3x_i2s_playcap.2.auto<http://2.auto>
>>
>> by using MFD we can make it happen automatically by giving
>> "acp3x_i2s_playcap" and other extension will be added by MFD add device API.
> 
> The auto extension is handed by the platform_deivce_alloc() API.
> 
>    platform_device_alloc("acp3x_i2s_playcap", PLATFORM_DEVID_AUTO);
> 
>> This helps us by rectifying the renaming issue which we get by using
>> Platform_dev_create API`s.If we have to use platform related APIs then
>> we need to give different naming conventions while creating the devices
>> and cant use it in loop as we have 3 devices we need to call three
>> explicitly.This make our code lengthy.
>> If we use MFD it would help us a lot.
>>
>> Please suggest us how can we proceed.
> 
> You have 2 choices available to you based on whether your device is an
> MFD or not:
> 
> If yes, move it (or a part of it) to drivers/mfd.
> If no, then use the platform_device_*() API.
>