linux-kernel - [PATCH v3 4/5] exit: use pid_has_task() in do

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 17 Oct 2019 12:18:31 +0200
From:   Christian Brauner <christian.brauner@...ntu.com>
To:     oleg@...hat.com, linux-kernel@...r.kernel.org
Cc:     aarcange@...hat.com, akpm@...ux-foundation.org,
        christian@...lner.me, cyphar@...har.com, elena.reshetova@...el.com,
        guro@...com, jannh@...gle.com, ldv@...linux.org,
        linux-api@...r.kernel.org, linux-kselftest@...r.kernel.org,
        mhocko@...e.com, mingo@...nel.org, peterz@...radead.org,
        shuah@...nel.org, tglx@...utronix.de, viro@...iv.linux.org.uk,
        Christian Brauner <christian.brauner@...ntu.com>
Subject: [PATCH v3 4/5] exit: use pid_has_task() in do_wait()

Replace hlist_empty() with the new pid_has_task() helper which is more
idiomatic, easier to grep for, and unifies how callers perform this check.

Signed-off-by: Christian Brauner <christian.brauner@...ntu.com>
Reviewed-by: Oleg Nesterov <oleg@...hat.com>
---
/* pidfd selftests */
passed

/* v1 */
patch not present

/* v2 */
Link: https://lore.kernel.org/r/20191016153606.2326-4-christian.brauner@ubuntu.com
patch introduced

/* v3 */
- Oleg Nesterov <oleg@...hat.com>:
  - s/task_alive/pid_has_task/
---
 kernel/exit.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/kernel/exit.c b/kernel/exit.c
index a46a50d67002..f2d20ab74422 100644
--- a/kernel/exit.c
+++ b/kernel/exit.c
@@ -1457,7 +1457,7 @@ static long do_wait(struct wait_opts *wo)
 	 */
 	wo->notask_error = -ECHILD;
 	if ((wo->wo_type < PIDTYPE_MAX) &&
-	   (!wo->wo_pid || hlist_empty(&wo->wo_pid->tasks[wo->wo_type])))
+	   (!wo->wo_pid || !pid_has_task(wo->wo_pid, wo->wo_type)))
 		goto notask;
 
 	set_current_state(TASK_INTERRUPTIBLE);
-- 
2.23.0